You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "SiyaoIsHiding (via GitHub)" <gi...@apache.org> on 2024/08/12 22:43:19 UTC

[PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

SiyaoIsHiding opened a new pull request, #103:
URL: https://github.com/apache/cassandra-builds/pull/103

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever closed pull request #103: CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver
URL: https://github.com/apache/cassandra-builds/pull/103


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1755319464


##########
jenkins-dsl/cassandra_job_dsl_seed.groovy:
##########
@@ -1471,3 +1471,18 @@ job('contribulyze') {
         }
     }
 }
+
+multibranchPipelineJob('multi-branch-java-driver') {
+    branchSources {
+        github {
+            id('123') 

Review Comment:
   ```suggestion
               id('123') 
               scanCredentialsId('ASF CI for Github PRs etc')
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1732272569


##########
docker/testing/ubuntu2204_java_driver_testing:
##########
@@ -0,0 +1,62 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+MAINTAINER Apache Cassandra <de...@cassandra.apache.org>
+
+RUN export DEBIAN_FRONTEND=noninteractive && \
+	apt update  && \
+	apt install -y curl git virtualenv software-properties-common vim maven sudo && \
+	add-apt-repository -y ppa:deadsnakes/ppa && \
+	apt update
+
+# set up python 3.9
+RUN DEBIAN_FRONTEND=nointeractive apt install -y python3.9
+RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.9 1
+
+# add user
+RUN useradd -rm -d /home/docker -s /bin/bash -g root -G sudo -u 1000 -p "$(openssl passwd -1 docker)" docker
+RUN echo "docker ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
+
+USER docker
+
+WORKDIR /home/docker
+
+# install jabba and java versions
+RUN export JABBA_HOME="$HOME/.jabba" && \
+	curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | bash && . "$HOME/.jabba/jabba.sh" && \
+	jabba install zulu@1.8 && \
+	jabba install openjdk@1.11.0 && \
+	jabba install openjdk@1.17.0
+
+ENV PATH="/home/docker/.jabba/bin:/home/docker/.local/bin:$PATH"
+
+RUN echo "export JAVA8_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo "export JAVA11_HOME=$(jabba which openjdk@1.11.0)" >> ~/env.txt && \
+	  echo "export JAVA17_HOME=$(jabba which openjdk@1.17.0)" >> ~/env.txt && \
+  	echo "export JAVA_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo ". $HOME/.jabba/jabba.sh" >> ~/env.txt && \
+  	echo "jabba use zulu@1.8" >> ~/env.txt
+
+# ccm
+RUN git clone https://github.com/riptano/ccm.git  && \
+	cd ccm && \
+	pip install -e .
+
+# driver
+RUN git clone https://github.com/apache/cassandra-java-driver.git

Review Comment:
   see my branch of your cassandra-java-driver patch.
   i mount the current directory into docker
   https://github.com/SiyaoIsHiding/java-driver/compare/asf-ci-3.x...thelastpickle:cassandra-java-driver:mck/Siyaso/asf-ci-3.x#diff-6e6a535c03e06e3c8fbb6c401d7daac3eb1df13f4664267168521f31f1cc3df8R24
   
   with that in place you don't need line 56 above (you don't need to git clone inside the image)*
   
   ref: https://github.com/SiyaoIsHiding/java-driver/compare/asf-ci-3.x...thelastpickle:cassandra-java-driver:mck/Siyaso/asf-ci-3.x
   
   *) a valid reason to git clone is if you want to do a build so that ~/.m2/repository has most of the dependencies ready to go in the image.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1730313808


##########
docker/testing/ubuntu2204_java_driver_testing:
##########
@@ -0,0 +1,62 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+MAINTAINER Apache Cassandra <de...@cassandra.apache.org>
+
+RUN export DEBIAN_FRONTEND=noninteractive && \
+	apt update  && \
+	apt install -y curl git virtualenv software-properties-common vim maven sudo && \
+	add-apt-repository -y ppa:deadsnakes/ppa && \
+	apt update
+
+# set up python 3.9
+RUN DEBIAN_FRONTEND=nointeractive apt install -y python3.9
+RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.9 1
+
+# add user
+RUN useradd -rm -d /home/docker -s /bin/bash -g root -G sudo -u 1000 -p "$(openssl passwd -1 docker)" docker
+RUN echo "docker ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
+
+USER docker
+
+WORKDIR /home/docker
+
+# install jabba and java versions
+RUN export JABBA_HOME="$HOME/.jabba" && \
+	curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | bash && . "$HOME/.jabba/jabba.sh" && \
+	jabba install zulu@1.8 && \
+	jabba install openjdk@1.11.0 && \
+	jabba install openjdk@1.17.0
+
+ENV PATH="/home/docker/.jabba/bin:/home/docker/.local/bin:$PATH"
+
+RUN echo "export JAVA8_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo "export JAVA11_HOME=$(jabba which openjdk@1.11.0)" >> ~/env.txt && \
+	  echo "export JAVA17_HOME=$(jabba which openjdk@1.17.0)" >> ~/env.txt && \
+  	echo "export JAVA_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo ". $HOME/.jabba/jabba.sh" >> ~/env.txt && \
+  	echo "jabba use zulu@1.8" >> ~/env.txt
+
+# ccm
+RUN git clone https://github.com/riptano/ccm.git  && \
+	cd ccm && \
+	pip install -e .
+
+# driver
+RUN git clone https://github.com/apache/cassandra-java-driver.git

Review Comment:
   how will you switch to the git fork and branch that you want to be testing …? 
   (alternative can be to mount the current directory here instead)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#issuecomment-2296953341

   we want to update `jenkins-dsl/cassandra_job_dsl_seed.groovy` too (to add the jenkins job)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1750676696


##########
docker/testing/ubuntu2204_java_driver_testing:
##########
@@ -0,0 +1,62 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+MAINTAINER Apache Cassandra <de...@cassandra.apache.org>
+
+RUN export DEBIAN_FRONTEND=noninteractive && \
+	apt update  && \
+	apt install -y curl git virtualenv software-properties-common vim maven sudo && \
+	add-apt-repository -y ppa:deadsnakes/ppa && \
+	apt update
+
+# set up python 3.9
+RUN DEBIAN_FRONTEND=nointeractive apt install -y python3.9
+RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.9 1
+
+# add user
+RUN useradd -rm -d /home/docker -s /bin/bash -g root -G sudo -u 1000 -p "$(openssl passwd -1 docker)" docker
+RUN echo "docker ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
+
+USER docker
+
+WORKDIR /home/docker
+
+# install jabba and java versions
+RUN export JABBA_HOME="$HOME/.jabba" && \
+	curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | bash && . "$HOME/.jabba/jabba.sh" && \
+	jabba install zulu@1.8 && \
+	jabba install openjdk@1.11.0 && \
+	jabba install openjdk@1.17.0
+
+ENV PATH="/home/docker/.jabba/bin:/home/docker/.local/bin:$PATH"
+
+RUN echo "export JAVA8_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo "export JAVA11_HOME=$(jabba which openjdk@1.11.0)" >> ~/env.txt && \
+	  echo "export JAVA17_HOME=$(jabba which openjdk@1.17.0)" >> ~/env.txt && \
+  	echo "export JAVA_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo ". $HOME/.jabba/jabba.sh" >> ~/env.txt && \
+  	echo "jabba use zulu@1.8" >> ~/env.txt
+
+# ccm
+RUN git clone https://github.com/riptano/ccm.git  && \
+	cd ccm && \
+	pip install -e .
+
+# driver
+RUN git clone https://github.com/apache/cassandra-java-driver.git

Review Comment:
   I deleted the git clone command



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#issuecomment-2343302344

   Created https://issues.apache.org/jira/browse/INFRA-26104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1753951028


##########
docker/testing/ubuntu2204_java_driver_testing:
##########
@@ -0,0 +1,56 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+MAINTAINER Apache Cassandra <de...@cassandra.apache.org>
+
+RUN export DEBIAN_FRONTEND=noninteractive && \
+	apt update  && \
+	apt install -y curl git virtualenv software-properties-common vim maven sudo && \
+	add-apt-repository -y ppa:deadsnakes/ppa && \
+	apt update
+
+# set up python 3.9
+RUN DEBIAN_FRONTEND=nointeractive apt install -y python3.9
+RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.9 1
+
+# add user
+RUN useradd -rm -d /home/docker -s /bin/bash -g root -G sudo -u 1000 -p "$(openssl passwd -1 docker)" docker
+RUN echo "docker ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
+
+USER docker
+
+WORKDIR /home/docker
+
+# install jabba and java versions
+RUN export JABBA_HOME="$HOME/.jabba" && \
+	curl -sL https://github.com/Jabba-Team/jabba/raw/main/install.sh | bash && . /home/docker/.jabba/jabba.sh
+	
+RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@1.8.0-292
+RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@1.11.0-9
+RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@17
+
+ENV PATH="/home/docker/.jabba/bin:/home/docker/.local/bin:$PATH"
+
+RUN echo "export JAVA8_HOME=$(jabba which openjdk@1.8.0-292)" >> ~/env.txt && \
+  	echo "export JAVA11_HOME=$(jabba which openjdk@1.11.0-9)" >> ~/env.txt && \
+	echo "export JAVA17_HOME=$(jabba which openjdk@17)" >> ~/env.txt && \
+  	echo "export JAVA_HOME=$(jabba which openjdk@1.8.0-292)" >> ~/env.txt && \
+  	echo ". $HOME/.jabba/jabba.sh" >> ~/env.txt && \
+  	echo "jabba use openjdk@1.8.0-292" >> ~/env.txt
+
+# ccm
+RUN git clone https://github.com/riptano/ccm.git  && \
+	cd ccm && \
+	pip install -e .

Review Comment:
   is this version of ccm then baked into the image? 
   how do we test against newer versions of ccm ? what if the driver needs a newer ccm version to pass CI ?
   (we don't have to have a fix here, just have awareness of this)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#issuecomment-2299953633

   Updated the `jenkins-dsl/cassandra_job_dsl_seed.groovy`!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1732272569


##########
docker/testing/ubuntu2204_java_driver_testing:
##########
@@ -0,0 +1,62 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+MAINTAINER Apache Cassandra <de...@cassandra.apache.org>
+
+RUN export DEBIAN_FRONTEND=noninteractive && \
+	apt update  && \
+	apt install -y curl git virtualenv software-properties-common vim maven sudo && \
+	add-apt-repository -y ppa:deadsnakes/ppa && \
+	apt update
+
+# set up python 3.9
+RUN DEBIAN_FRONTEND=nointeractive apt install -y python3.9
+RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.9 1
+
+# add user
+RUN useradd -rm -d /home/docker -s /bin/bash -g root -G sudo -u 1000 -p "$(openssl passwd -1 docker)" docker
+RUN echo "docker ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
+
+USER docker
+
+WORKDIR /home/docker
+
+# install jabba and java versions
+RUN export JABBA_HOME="$HOME/.jabba" && \
+	curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | bash && . "$HOME/.jabba/jabba.sh" && \
+	jabba install zulu@1.8 && \
+	jabba install openjdk@1.11.0 && \
+	jabba install openjdk@1.17.0
+
+ENV PATH="/home/docker/.jabba/bin:/home/docker/.local/bin:$PATH"
+
+RUN echo "export JAVA8_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo "export JAVA11_HOME=$(jabba which openjdk@1.11.0)" >> ~/env.txt && \
+	  echo "export JAVA17_HOME=$(jabba which openjdk@1.17.0)" >> ~/env.txt && \
+  	echo "export JAVA_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo ". $HOME/.jabba/jabba.sh" >> ~/env.txt && \
+  	echo "jabba use zulu@1.8" >> ~/env.txt
+
+# ccm
+RUN git clone https://github.com/riptano/ccm.git  && \
+	cd ccm && \
+	pip install -e .
+
+# driver
+RUN git clone https://github.com/apache/cassandra-java-driver.git

Review Comment:
   see my branch of your cassandra-java-driver patch.
   i mount the current directory into docker
   https://github.com/SiyaoIsHiding/java-driver/compare/asf-ci-3.x...thelastpickle:cassandra-java-driver:mck/Siyaso/asf-ci-3.x#diff-6e6a535c03e06e3c8fbb6c401d7daac3eb1df13f4664267168521f31f1cc3df8R24
   
   with that in place you don't need line 56 above (you don't need to git clone inside the image)*
   
   ref: https://github.com/SiyaoIsHiding/java-driver/compare/asf-ci-3.x...thelastpickle:cassandra-java-driver:mck/Siyaso/asf-ci-3.x
   
   *) note, a valid reason to still do the git clone is if you want to do a build so that ~/.m2/repository has most of the dependencies ready to go in the image. (after the build is done you can delete the clone)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1731815311


##########
docker/testing/ubuntu2204_java_driver_testing:
##########
@@ -0,0 +1,62 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+MAINTAINER Apache Cassandra <de...@cassandra.apache.org>
+
+RUN export DEBIAN_FRONTEND=noninteractive && \
+	apt update  && \
+	apt install -y curl git virtualenv software-properties-common vim maven sudo && \
+	add-apt-repository -y ppa:deadsnakes/ppa && \
+	apt update
+
+# set up python 3.9
+RUN DEBIAN_FRONTEND=nointeractive apt install -y python3.9
+RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.9 1
+
+# add user
+RUN useradd -rm -d /home/docker -s /bin/bash -g root -G sudo -u 1000 -p "$(openssl passwd -1 docker)" docker
+RUN echo "docker ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
+
+USER docker
+
+WORKDIR /home/docker
+
+# install jabba and java versions
+RUN export JABBA_HOME="$HOME/.jabba" && \
+	curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | bash && . "$HOME/.jabba/jabba.sh" && \
+	jabba install zulu@1.8 && \
+	jabba install openjdk@1.11.0 && \
+	jabba install openjdk@1.17.0
+
+ENV PATH="/home/docker/.jabba/bin:/home/docker/.local/bin:$PATH"
+
+RUN echo "export JAVA8_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo "export JAVA11_HOME=$(jabba which openjdk@1.11.0)" >> ~/env.txt && \
+	  echo "export JAVA17_HOME=$(jabba which openjdk@1.17.0)" >> ~/env.txt && \
+  	echo "export JAVA_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo ". $HOME/.jabba/jabba.sh" >> ~/env.txt && \
+  	echo "jabba use zulu@1.8" >> ~/env.txt
+
+# ccm
+RUN git clone https://github.com/riptano/ccm.git  && \
+	cd ccm && \
+	pip install -e .
+
+# driver
+RUN git clone https://github.com/apache/cassandra-java-driver.git

Review Comment:
   When used as a user's development environment, I thought the user can just add their own git remote and switch to the branch for development. As used in the Jenkins job, previously it worked for the jenkins job because jenkins checkout the fork/branch for me when I used the docker image at the agent level.
   Mounting the current directory also sounds good to me. Anything I need to change here for the docker definition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#issuecomment-2338724892

   FYI, the command I used to build the docker image is `docker buildx build --platform linux/amd64,linux/arm64 . -t janehe/cassandra-java-driver-dev-env --push`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#issuecomment-2344431739

   Committed as https://github.com/apache/cassandra-builds/commit/8ea262ac34d2505f045aa764de47ac15ea426908
   
   removed trailing spaces and replaced tabs to spaces.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1730313808


##########
docker/testing/ubuntu2204_java_driver_testing:
##########
@@ -0,0 +1,62 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+MAINTAINER Apache Cassandra <de...@cassandra.apache.org>
+
+RUN export DEBIAN_FRONTEND=noninteractive && \
+	apt update  && \
+	apt install -y curl git virtualenv software-properties-common vim maven sudo && \
+	add-apt-repository -y ppa:deadsnakes/ppa && \
+	apt update
+
+# set up python 3.9
+RUN DEBIAN_FRONTEND=nointeractive apt install -y python3.9
+RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.9 1
+
+# add user
+RUN useradd -rm -d /home/docker -s /bin/bash -g root -G sudo -u 1000 -p "$(openssl passwd -1 docker)" docker
+RUN echo "docker ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
+
+USER docker
+
+WORKDIR /home/docker
+
+# install jabba and java versions
+RUN export JABBA_HOME="$HOME/.jabba" && \
+	curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | bash && . "$HOME/.jabba/jabba.sh" && \
+	jabba install zulu@1.8 && \
+	jabba install openjdk@1.11.0 && \
+	jabba install openjdk@1.17.0
+
+ENV PATH="/home/docker/.jabba/bin:/home/docker/.local/bin:$PATH"
+
+RUN echo "export JAVA8_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo "export JAVA11_HOME=$(jabba which openjdk@1.11.0)" >> ~/env.txt && \
+	  echo "export JAVA17_HOME=$(jabba which openjdk@1.17.0)" >> ~/env.txt && \
+  	echo "export JAVA_HOME=$(jabba which zulu@1.8)" >> ~/env.txt && \
+  	echo ". $HOME/.jabba/jabba.sh" >> ~/env.txt && \
+  	echo "jabba use zulu@1.8" >> ~/env.txt
+
+# ccm
+RUN git clone https://github.com/riptano/ccm.git  && \
+	cd ccm && \
+	pip install -e .
+
+# driver
+RUN git clone https://github.com/apache/cassandra-java-driver.git

Review Comment:
   how will you switch to the git fork and branch that you want to be testing …? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1753931736


##########
jenkins-dsl/cassandra_job_dsl_seed.groovy:
##########
@@ -1471,3 +1471,18 @@ job('contribulyze') {
         }
     }
 }
+
+multibranchPipelineJob('multi-branch-java-driver') {

Review Comment:
   ```suggestion
   multibranchPipelineJob('cassandra-java-driver') {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]

Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on code in PR #103:
URL: https://github.com/apache/cassandra-builds/pull/103#discussion_r1755333158


##########
docker/testing/ubuntu2204_java_driver_testing:
##########
@@ -0,0 +1,56 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+MAINTAINER Apache Cassandra <de...@cassandra.apache.org>
+
+RUN export DEBIAN_FRONTEND=noninteractive && \
+	apt update  && \
+	apt install -y curl git virtualenv software-properties-common vim maven sudo && \
+	add-apt-repository -y ppa:deadsnakes/ppa && \
+	apt update
+
+# set up python 3.9
+RUN DEBIAN_FRONTEND=nointeractive apt install -y python3.9
+RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.9 1
+
+# add user
+RUN useradd -rm -d /home/docker -s /bin/bash -g root -G sudo -u 1000 -p "$(openssl passwd -1 docker)" docker
+RUN echo "docker ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
+
+USER docker
+
+WORKDIR /home/docker
+
+# install jabba and java versions
+RUN export JABBA_HOME="$HOME/.jabba" && \
+	curl -sL https://github.com/Jabba-Team/jabba/raw/main/install.sh | bash && . /home/docker/.jabba/jabba.sh
+	
+RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@1.8.0-292
+RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@1.11.0-9
+RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@17
+
+ENV PATH="/home/docker/.jabba/bin:/home/docker/.local/bin:$PATH"
+
+RUN echo "export JAVA8_HOME=$(jabba which openjdk@1.8.0-292)" >> ~/env.txt && \
+  	echo "export JAVA11_HOME=$(jabba which openjdk@1.11.0-9)" >> ~/env.txt && \
+	echo "export JAVA17_HOME=$(jabba which openjdk@17)" >> ~/env.txt && \
+  	echo "export JAVA_HOME=$(jabba which openjdk@1.8.0-292)" >> ~/env.txt && \
+  	echo ". $HOME/.jabba/jabba.sh" >> ~/env.txt && \
+  	echo "jabba use openjdk@1.8.0-292" >> ~/env.txt
+
+# ccm
+RUN git clone https://github.com/riptano/ccm.git  && \
+	cd ccm && \
+	pip install -e .

Review Comment:
   Yes, it is baked into the image, same for other drivers' Jenkins AMI images. We just need to rebuild the images later when we want newer ccm.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org