You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/29 05:51:45 UTC
[GitHub] [pulsar] congbobo184 opened a new pull request #10741: [Transaction] Fix transaction ack delete marker position when don't have transaction ack.
congbobo184 opened a new pull request #10741:
URL: https://github.com/apache/pulsar/pull/10741
## Motivation
Now when broke enable transaction, every ack will check the next position is transaction marker position whether or not. When don't have transaction ack, we don' need to check the next position is transaction marker position.
## implement
```
add the judgement for pending ack delete transaction marker position.
```
### Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (yes)
Anything that affects deployment: (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 merged pull request #10741: [Transaction] Fix transaction ack delete marker position when don't have transaction ack.
Posted by GitBox <gi...@apache.org>.
congbobo184 merged pull request #10741:
URL: https://github.com/apache/pulsar/pull/10741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #10741: [Transaction] Fix transaction ack delete marker position when don't have transaction ack.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #10741:
URL: https://github.com/apache/pulsar/pull/10741#discussion_r641980053
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/PendingAckHandle.java
##########
@@ -152,4 +152,11 @@
* @return the future of this operation.
*/
CompletableFuture<Void> close();
+
+ /**
+ * Is transaction ack existed.
+ *
+ * @return the the boolean of teansaction ack existed.
+ */
+ boolean isTransactionAckExisted();
Review comment:
What about 'isTransactionAckPresent' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org