[GitHub] [spark] hvanhovell commented on a diff in pull request #40467: [SPARK-42584][CONNECT] Improve output of `Column.explain`

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #40467:
URL: https://github.com/apache/spark/pull/40467#discussion_r1144160497


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -1211,13 +1211,11 @@ class Column private[sql] (private[sql] val expr: proto.Expression) extends Logg
    * @group df_ops
    * @since 3.4.0
    */
-  def explain(extended: Boolean): Unit = {
+  def explain(extended: Boolean)(implicit spark: SparkSession): Unit = {

Review Comment:
   I am not sure what happened here, my comment seemed to have gone missing... Anyway, please don't send an RPC for this. Just use the local expression tree and create something that is a little bit easier to read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org