You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/07/27 20:09:15 UTC
[GitHub] [fineract] wkigenyi opened a new pull request, #2458: correct descriptions and summary on DELETE and PUT
wkigenyi opened a new pull request, #2458:
URL: https://github.com/apache/fineract/pull/2458
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2458: correct descriptions and summary on DELETE and PUT
Posted by GitBox <gi...@apache.org>.
vidakovic commented on PR #2458:
URL: https://github.com/apache/fineract/pull/2458#issuecomment-1229411221
@wkigenyi ... could you please create a Jira ticket - a generic one... something like "Ongoing OpenAPI fixes" - for ongoing improvements of the OpenAPI manifest/annotations and format this PR title properly (e. g. "FINERACT-XXXX: Ongoing OpenAPI fixes - GL Account"; even if we ignore the reference to a Jira ticket (important for changelog when we do releases) then your current title does not give any indication where these changes are applied (we have a lot of DELETE and PUT annotated endpoints). Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2458: FINERACT-1724: Correct descriptions and summary on DELETE and PUT
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2458:
URL: https://github.com/apache/fineract/pull/2458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2458: correct descriptions and summary on DELETE and PUT
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2458:
URL: https://github.com/apache/fineract/pull/2458#issuecomment-1197876572
Please do a `./gradlew spotlessApply` and then the tests will pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] jdailey commented on pull request #2458: correct descriptions and summary on DELETE and PUT
Posted by GitBox <gi...@apache.org>.
jdailey commented on PR #2458:
URL: https://github.com/apache/fineract/pull/2458#issuecomment-1234789983
This isn't linked properly to a Jira ticket . please correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2458: correct descriptions and summary on DELETE and PUT
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #2458:
URL: https://github.com/apache/fineract/pull/2458#issuecomment-1229344975
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] wkigenyi commented on pull request #2458: correct descriptions and summary on DELETE and PUT
Posted by GitBox <gi...@apache.org>.
wkigenyi commented on PR #2458:
URL: https://github.com/apache/fineract/pull/2458#issuecomment-1229480753
Will do in a about 3 hours. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2458: correct descriptions and summary on DELETE and PUT
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #2458:
URL: https://github.com/apache/fineract/pull/2458#issuecomment-1264515228
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org