You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2015/10/22 09:11:06 UTC
[QUESTION about OFBIZ-6618] growerptest Selenium component out or
in OFBiz?
Hi,
There is a WIP in the GrowErp community on a growerptest Selenium component, see https://issues.apache.org/jira/browse/OFBIZ-6618
The commit r1709516 introduced a small change to have it working OOTB when you put it in hot-deploy
The question is: do we agree with this way of doing and let the GrowErp community handles the component out of OFBiz, or should we handle it ourselves?
Thanks for your opinions
Jacques
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out or
in OFBiz?
Posted by Hans Bakker <h....@antwebsystems.com>.
Nicolas,
as explained before this java call is just a hook to an external java
program which is called when the new test type is used which was added
to the XSD as part of the patch. The required code can be added to the
hot-deploy directory. We provided an example component with
documentation how to use this hook in the growerptest component at
https://gerrit.antwebsystems.com/#/admin/projects/growerptest
The component has the Apache 2.0 license, so free to download and
contains all the documentation and example tests.
Please study that first?
Regards,
Hans
PS1. Nicolas, you forced last time the change in the 'addPartyRole'
which I gave up on and which caused other problems in the system
(SFA,setup and others) which i told you would happen. If you want this
hook taken out , i am fine and i will contribute less and less to the
core system because all the lengthy discussions.
PS2.Please note that this is also the last time i have something to say
about this change.
On 10/11/15 03:59, Nicolas Malin wrote:
> Hello,
>
> I arrive after the war but :)
> This issue is interesting for many points and I keep :
> * ModelTestSuite.java I'm afraid to see dead code, the call 'if
> ("webdriver-test".equals(nodeName)' will be never use for a standard
> OFBiz and some new user won't understand why we call a non existent
> java class. I understand that we can load from third part but ... if
> all third community do the same way, how to maintain them in OFBiz
> without making committer crazy ?
> * I check the growerptest to control if it can be load on OFBiz
> directly, but the code don't respect the coding convention and is
> missing the minimum documentation like the xsd. I think it's really
> interesting for the both community to improve the growerptest quality
> ** For OFBiz to have an other test case
> ** For GrowErp community to improve the code quality and minimize
> the maintenance
>
> I can read and try to improve the code but from grow erp do you want
> participate to improve some part ?
>
> Nicolas
>
> Le 23/10/2015 07:23, Hans Bakker a écrit :
>> Hi Jacques, thanks for bringing this up.
>>
>> 1. this changes in the framework is a pretty general one, any
>> external test system can use it. It is not specific for the component
>> we provided. It is actually just an example that Ruud created, on how
>> you can use this 'hook'. Yes the change is not more than a 'hook'
>> 2. We should implement more of these kind of hooks. I have another
>> one: Did you ever try to create a component with its own menu system?
>> We have the growerp backend as an example how to do that. Is the
>> community interested in this menu hook?
>> 3. Further, this growerptest component we provide is not a work in
>> progress any more, it has the apache 2 license, can be included into
>> ofbiz if you want, and as I said before, i can even provide
>> peer-write access to the component for people who want to contribute.
>>
>> If you have any further questions, let me know.
>>
>> Regards, Hans
>>
>> On 22/10/15 14:11, Jacques Le Roux wrote:
>>> Hi,
>>>
>>> There is a WIP in the GrowErp community on a growerptest Selenium
>>> component, see https://issues.apache.org/jira/browse/OFBIZ-6618
>>>
>>> The commit r1709516 introduced a small change to have it working
>>> OOTB when you put it in hot-deploy
>>>
>>> The question is: do we agree with this way of doing and let the
>>> GrowErp community handles the component out of OFBiz, or should we
>>> handle it ourselves?
>>>
>>> Thanks for your opinions
>>>
>>> Jacques
>>
>>
--
Regards,
Hans Bakker
CEO, http://antwebsystems.com
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out or
in OFBiz?
Posted by Nicolas Malin <ni...@nereide.fr>.
Hello,
I arrive after the war but :)
This issue is interesting for many points and I keep :
* ModelTestSuite.java I'm afraid to see dead code, the call 'if
("webdriver-test".equals(nodeName)' will be never use for a standard
OFBiz and some new user won't understand why we call a non existent java
class. I understand that we can load from third part but ... if all
third community do the same way, how to maintain them in OFBiz without
making committer crazy ?
* I check the growerptest to control if it can be load on OFBiz
directly, but the code don't respect the coding convention and is
missing the minimum documentation like the xsd. I think it's really
interesting for the both community to improve the growerptest quality
** For OFBiz to have an other test case
** For GrowErp community to improve the code quality and minimize
the maintenance
I can read and try to improve the code but from grow erp do you want
participate to improve some part ?
Nicolas
Le 23/10/2015 07:23, Hans Bakker a écrit :
> Hi Jacques, thanks for bringing this up.
>
> 1. this changes in the framework is a pretty general one, any external
> test system can use it. It is not specific for the component we
> provided. It is actually just an example that Ruud created, on how you
> can use this 'hook'. Yes the change is not more than a 'hook'
> 2. We should implement more of these kind of hooks. I have another
> one: Did you ever try to create a component with its own menu system?
> We have the growerp backend as an example how to do that. Is the
> community interested in this menu hook?
> 3. Further, this growerptest component we provide is not a work in
> progress any more, it has the apache 2 license, can be included into
> ofbiz if you want, and as I said before, i can even provide peer-write
> access to the component for people who want to contribute.
>
> If you have any further questions, let me know.
>
> Regards, Hans
>
> On 22/10/15 14:11, Jacques Le Roux wrote:
>> Hi,
>>
>> There is a WIP in the GrowErp community on a growerptest Selenium
>> component, see https://issues.apache.org/jira/browse/OFBIZ-6618
>>
>> The commit r1709516 introduced a small change to have it working OOTB
>> when you put it in hot-deploy
>>
>> The question is: do we agree with this way of doing and let the
>> GrowErp community handles the component out of OFBiz, or should we
>> handle it ourselves?
>>
>> Thanks for your opinions
>>
>> Jacques
>
>
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out
or in OFBiz?
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Gil,
That's also my opinions, because this component is technical. I even wonder if it should not be part of the framework; though that would be against
the work done by the new framework proposition team at
https://cwiki.apache.org/confluence/display/OFBIZ/A+New+Application+Framework+Design
On the other hand, thinking more about specialpurpose components, I wonder if components like
ebay
ebaystore
googlebase
googlecheckout
passport
next comming magento component
[you name it...]
should not be maintained apart of the ASF repo but documented in our wiki.
If we keep such components in OFBiz, one thing we could maybe do is creating sub-folders, for instance under ecommerce for the components above, or
another ecomcomplements component to put them. We begin to have much of them in an unstructured way...
Jacques
Le 24/10/2015 12:12, gil portenseigne a écrit :
> Hi Pierre, Jacques and all,
>
> I didn't find time to see what there is in Antweb component, so my opinion will be based on my own experience.
> I think that if the functionnalities provided are very standard and could be used by most/lot of OFBiz integrators (testing purpose is one of those
> in my point of view), it will be best to have it into apache repository.
>
> That because of the marketing aspect of OFBiz providing more complete testing tools, the visibility and the maintainability eased by apache infra,
> and so on...
>
> Indeed it's a community decision to have it integrated, but the status of "being maintained in another repo" must not be an obstacle to contributing
> into Apache OFBiz source code.
> This might lead to loss of potential contribution because it's easier to anybody to manage each own repository and to subscribe in OEM for example.
>
> Don't get me wrong, i think that OEM is a good thing, but for uncontributable solutions due to licencing, specific purpose and many other reasons...
> but not for lazyness or so (that's my fear). I even think that the OEM community should have the goal to test the solutions and detect if some are
> contributable...
>
> About adding code into Apache OFBiz repo to make external tools able to work I find it quite strange, i'd rather see a patch in the external
> solution to allow its use. But it can be the first step toward contribution of the solution...
>
> Best Regards
>
> Gil
>
>
>
>
> On 24/10/2015 09:55, Pierre Smits wrote:
>> The patch added to the framework could just as easily be captured in the
>> intended component, extending the ModelTestSuite.java file. That way the
>> component works fairly independent and when users don't want this they
>> won't have superfluous code in their implementation. While I agree that
>> testing is important, users can easily pull the code from the antweb repos
>> and work from there, so there is actually no need to bundle it into the
>> OFBiz code base. This is something one wouldn't use in a production
>> environment (unless testing is your business).
>>
>> Best regards,
>>
>>
>> Pierre Smits
>>
>> *OFBiz Extensions Marketplace*
>> http://oem.ofbizci.net/oci-2/
>>
>> On Fri, Oct 23, 2015 at 9:41 AM, Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>>
>>> Hi Hans, inline
>>>
>>> Le 23/10/2015 07:23, Hans Bakker a écrit :
>>>
>>>> Hi Jacques, thanks for bringing this up.
>>>>
>>>> 1. this changes in the framework is a pretty general one, any external
>>>> test system can use it. It is not specific for the component we provided.
>>>> It is actually just an example that Ruud created, on how you can use this
>>>> 'hook'. Yes the change is not more than a 'hook'
>>>>
>>> Agreed
>>>
>>> 2. We should implement more of these kind of hooks. I have another one:
>>>> Did you ever try to create a component with its own menu system? We have
>>>> the growerp backend as an example how to do that. Is the community
>>>> interested in this menu hook?
>>>>
>>> I guess, to be interested we should have some code to see, why not
>>> creating a Jira?
>>>
>>> 3. Further, this growerptest component we provide is not a work in
>>>> progress any more, it has the apache 2 license, can be included into ofbiz
>>>> if you want, and as I said before, i can even provide peer-write access to
>>>> the component for people who want to contribute.
>>>>
>>> Thanks for the proposition, I'm all for including it as a spercialpurpose
>>> component. Being in OFBiz OOTB is the more visible place for everyone and
>>> the more appealing for contributions
>>>
>>> I closed the still opened remaining Selenium related OFBIZ-4189 and
>>> OFBIZ-3438 issues.
>>> I think we should replace
>>> https://cwiki.apache.org/confluence/display/OFBIZ/Pure+webdriver+implementation
>>> by the now common README + wiki page scheme we have in (some) other
>>> components.
>>>
>>> Jacques
>>>
>>>
>>>
>>>> If you have any further questions, let me know.
>>>>
>>>> Regards, Hans
>>>>
>>>> On 22/10/15 14:11, Jacques Le Roux wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> There is a WIP in the GrowErp community on a growerptest Selenium
>>>>> component, seehttps://issues.apache.org/jira/browse/OFBIZ-6618
>>>>>
>>>>> The commit r1709516 introduced a small change to have it working OOTB
>>>>> when you put it in hot-deploy
>>>>>
>>>>> The question is: do we agree with this way of doing and let the GrowErp
>>>>> community handles the component out of OFBiz, or should we handle it
>>>>> ourselves?
>>>>>
>>>>> Thanks for your opinions
>>>>>
>>>>> Jacques
>>>>>
>>>>
>
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out or
in OFBiz?
Posted by gil portenseigne <gi...@nereide.fr>.
Hi Pierre, Jacques and all,
I didn't find time to see what there is in Antweb component, so my
opinion will be based on my own experience.
I think that if the functionnalities provided are very standard and
could be used by most/lot of OFBiz integrators (testing purpose is one
of those in my point of view), it will be best to have it into apache
repository.
That because of the marketing aspect of OFBiz providing more complete
testing tools, the visibility and the maintainability eased by apache
infra, and so on...
Indeed it's a community decision to have it integrated, but the status
of "being maintained in another repo" must not be an obstacle to
contributing into Apache OFBiz source code.
This might lead to loss of potential contribution because it's easier to
anybody to manage each own repository and to subscribe in OEM for example.
Don't get me wrong, i think that OEM is a good thing, but for
uncontributable solutions due to licencing, specific purpose and many
other reasons... but not for lazyness or so (that's my fear). I even
think that the OEM community should have the goal to test the solutions
and detect if some are contributable...
About adding code into Apache OFBiz repo to make external tools able to
work I find it quite strange, i'd rather see a patch in the external
solution to allow its use. But it can be the first step toward
contribution of the solution...
Best Regards
Gil
On 24/10/2015 09:55, Pierre Smits wrote:
> The patch added to the framework could just as easily be captured in the
> intended component, extending the ModelTestSuite.java file. That way the
> component works fairly independent and when users don't want this they
> won't have superfluous code in their implementation. While I agree that
> testing is important, users can easily pull the code from the antweb repos
> and work from there, so there is actually no need to bundle it into the
> OFBiz code base. This is something one wouldn't use in a production
> environment (unless testing is your business).
>
> Best regards,
>
>
> Pierre Smits
>
> *OFBiz Extensions Marketplace*
> http://oem.ofbizci.net/oci-2/
>
> On Fri, Oct 23, 2015 at 9:41 AM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Hi Hans, inline
>>
>> Le 23/10/2015 07:23, Hans Bakker a écrit :
>>
>>> Hi Jacques, thanks for bringing this up.
>>>
>>> 1. this changes in the framework is a pretty general one, any external
>>> test system can use it. It is not specific for the component we provided.
>>> It is actually just an example that Ruud created, on how you can use this
>>> 'hook'. Yes the change is not more than a 'hook'
>>>
>> Agreed
>>
>> 2. We should implement more of these kind of hooks. I have another one:
>>> Did you ever try to create a component with its own menu system? We have
>>> the growerp backend as an example how to do that. Is the community
>>> interested in this menu hook?
>>>
>> I guess, to be interested we should have some code to see, why not
>> creating a Jira?
>>
>> 3. Further, this growerptest component we provide is not a work in
>>> progress any more, it has the apache 2 license, can be included into ofbiz
>>> if you want, and as I said before, i can even provide peer-write access to
>>> the component for people who want to contribute.
>>>
>> Thanks for the proposition, I'm all for including it as a spercialpurpose
>> component. Being in OFBiz OOTB is the more visible place for everyone and
>> the more appealing for contributions
>>
>> I closed the still opened remaining Selenium related OFBIZ-4189 and
>> OFBIZ-3438 issues.
>> I think we should replace
>> https://cwiki.apache.org/confluence/display/OFBIZ/Pure+webdriver+implementation
>> by the now common README + wiki page scheme we have in (some) other
>> components.
>>
>> Jacques
>>
>>
>>
>>> If you have any further questions, let me know.
>>>
>>> Regards, Hans
>>>
>>> On 22/10/15 14:11, Jacques Le Roux wrote:
>>>
>>>> Hi,
>>>>
>>>> There is a WIP in the GrowErp community on a growerptest Selenium
>>>> component, see https://issues.apache.org/jira/browse/OFBIZ-6618
>>>>
>>>> The commit r1709516 introduced a small change to have it working OOTB
>>>> when you put it in hot-deploy
>>>>
>>>> The question is: do we agree with this way of doing and let the GrowErp
>>>> community handles the component out of OFBiz, or should we handle it
>>>> ourselves?
>>>>
>>>> Thanks for your opinions
>>>>
>>>> Jacques
>>>>
>>>
>>>
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out or
in OFBiz?
Posted by Pierre Smits <pi...@gmail.com>.
The patch added to the framework could just as easily be captured in the
intended component, extending the ModelTestSuite.java file. That way the
component works fairly independent and when users don't want this they
won't have superfluous code in their implementation. While I agree that
testing is important, users can easily pull the code from the antweb repos
and work from there, so there is actually no need to bundle it into the
OFBiz code base. This is something one wouldn't use in a production
environment (unless testing is your business).
Best regards,
Pierre Smits
*OFBiz Extensions Marketplace*
http://oem.ofbizci.net/oci-2/
On Fri, Oct 23, 2015 at 9:41 AM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Hi Hans, inline
>
> Le 23/10/2015 07:23, Hans Bakker a écrit :
>
>> Hi Jacques, thanks for bringing this up.
>>
>> 1. this changes in the framework is a pretty general one, any external
>> test system can use it. It is not specific for the component we provided.
>> It is actually just an example that Ruud created, on how you can use this
>> 'hook'. Yes the change is not more than a 'hook'
>>
>
> Agreed
>
> 2. We should implement more of these kind of hooks. I have another one:
>> Did you ever try to create a component with its own menu system? We have
>> the growerp backend as an example how to do that. Is the community
>> interested in this menu hook?
>>
>
> I guess, to be interested we should have some code to see, why not
> creating a Jira?
>
> 3. Further, this growerptest component we provide is not a work in
>> progress any more, it has the apache 2 license, can be included into ofbiz
>> if you want, and as I said before, i can even provide peer-write access to
>> the component for people who want to contribute.
>>
>
> Thanks for the proposition, I'm all for including it as a spercialpurpose
> component. Being in OFBiz OOTB is the more visible place for everyone and
> the more appealing for contributions
>
> I closed the still opened remaining Selenium related OFBIZ-4189 and
> OFBIZ-3438 issues.
> I think we should replace
> https://cwiki.apache.org/confluence/display/OFBIZ/Pure+webdriver+implementation
> by the now common README + wiki page scheme we have in (some) other
> components.
>
> Jacques
>
>
>
>> If you have any further questions, let me know.
>>
>> Regards, Hans
>>
>> On 22/10/15 14:11, Jacques Le Roux wrote:
>>
>>> Hi,
>>>
>>> There is a WIP in the GrowErp community on a growerptest Selenium
>>> component, see https://issues.apache.org/jira/browse/OFBIZ-6618
>>>
>>> The commit r1709516 introduced a small change to have it working OOTB
>>> when you put it in hot-deploy
>>>
>>> The question is: do we agree with this way of doing and let the GrowErp
>>> community handles the component out of OFBiz, or should we handle it
>>> ourselves?
>>>
>>> Thanks for your opinions
>>>
>>> Jacques
>>>
>>
>>
>>
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out
or in OFBiz?
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Hans, inline
Le 23/10/2015 07:23, Hans Bakker a écrit :
> Hi Jacques, thanks for bringing this up.
>
> 1. this changes in the framework is a pretty general one, any external test system can use it. It is not specific for the component we provided. It
> is actually just an example that Ruud created, on how you can use this 'hook'. Yes the change is not more than a 'hook'
Agreed
> 2. We should implement more of these kind of hooks. I have another one: Did you ever try to create a component with its own menu system? We have the
> growerp backend as an example how to do that. Is the community interested in this menu hook?
I guess, to be interested we should have some code to see, why not creating a Jira?
> 3. Further, this growerptest component we provide is not a work in progress any more, it has the apache 2 license, can be included into ofbiz if you
> want, and as I said before, i can even provide peer-write access to the component for people who want to contribute.
Thanks for the proposition, I'm all for including it as a spercialpurpose component. Being in OFBiz OOTB is the more visible place for everyone and
the more appealing for contributions
I closed the still opened remaining Selenium related OFBIZ-4189 and OFBIZ-3438 issues.
I think we should replace https://cwiki.apache.org/confluence/display/OFBIZ/Pure+webdriver+implementation by the now common README + wiki page scheme
we have in (some) other components.
Jacques
>
> If you have any further questions, let me know.
>
> Regards, Hans
>
> On 22/10/15 14:11, Jacques Le Roux wrote:
>> Hi,
>>
>> There is a WIP in the GrowErp community on a growerptest Selenium component, see https://issues.apache.org/jira/browse/OFBIZ-6618
>>
>> The commit r1709516 introduced a small change to have it working OOTB when you put it in hot-deploy
>>
>> The question is: do we agree with this way of doing and let the GrowErp community handles the component out of OFBiz, or should we handle it
>> ourselves?
>>
>> Thanks for your opinions
>>
>> Jacques
>
>
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out
or in OFBiz?
Posted by Sharan-F <sh...@gmail.com>.
Hi Hans
The component with its own menu system sounds interesting.
Remember at Apachecon we talked about the possibility of setting up an OFBiz
Business Demo as an OFBiz component to showcase a a little of what OFBiz can
do. This could be a good use for such functionality.
Thanks
Sharan
--
View this message in context: http://ofbiz.135035.n4.nabble.com/QUESTION-about-OFBIZ-6618-growerptest-Selenium-component-out-or-in-OFBiz-tp4673747p4673784.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out or
in OFBiz?
Posted by Hans Bakker <h....@antwebsystems.com>.
Hi Jacques, thanks for bringing this up.
1. this changes in the framework is a pretty general one, any external
test system can use it. It is not specific for the component we
provided. It is actually just an example that Ruud created, on how you
can use this 'hook'. Yes the change is not more than a 'hook'
2. We should implement more of these kind of hooks. I have another one:
Did you ever try to create a component with its own menu system? We have
the growerp backend as an example how to do that. Is the community
interested in this menu hook?
3. Further, this growerptest component we provide is not a work in
progress any more, it has the apache 2 license, can be included into
ofbiz if you want, and as I said before, i can even provide peer-write
access to the component for people who want to contribute.
If you have any further questions, let me know.
Regards, Hans
On 22/10/15 14:11, Jacques Le Roux wrote:
> Hi,
>
> There is a WIP in the GrowErp community on a growerptest Selenium
> component, see https://issues.apache.org/jira/browse/OFBIZ-6618
>
> The commit r1709516 introduced a small change to have it working OOTB
> when you put it in hot-deploy
>
> The question is: do we agree with this way of doing and let the
> GrowErp community handles the component out of OFBiz, or should we
> handle it ourselves?
>
> Thanks for your opinions
>
> Jacques
--
Regards,
Hans Bakker
CEO, http://antwebsystems.com
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out
or in OFBiz?
Posted by Jacques Le Roux <ja...@les7arts.com>.
I mean: having the component maintained outside of OFBiz (official) svn repo as part of the GrowErp Git repo.
Hans, who I think is the owner of the GrowErp Git repo, said he could grant access to those interested.
You can find all that by yourself reading the Jira...
Jacques
Le 22/10/2015 13:54, Pierre Smits a écrit :
> Jacques,
>
> Can you explain a bit more with what you mean with 'this way of doing'?
>
> Best regards,
>
> Pierre Smits
>
> *OFBiz Extensions Marketplace*
> http://oem.ofbizci.net/oci-2/
>
> On Thu, Oct 22, 2015 at 9:11 AM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Hi,
>>
>> There is a WIP in the GrowErp community on a growerptest Selenium
>> component, see https://issues.apache.org/jira/browse/OFBIZ-6618
>>
>> The commit r1709516 introduced a small change to have it working OOTB when
>> you put it in hot-deploy
>>
>> The question is: do we agree with this way of doing and let the GrowErp
>> community handles the component out of OFBiz, or should we handle it
>> ourselves?
>>
>> Thanks for your opinions
>>
>> Jacques
>>
Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out or
in OFBiz?
Posted by Pierre Smits <pi...@gmail.com>.
Jacques,
Can you explain a bit more with what you mean with 'this way of doing'?
Best regards,
Pierre Smits
*OFBiz Extensions Marketplace*
http://oem.ofbizci.net/oci-2/
On Thu, Oct 22, 2015 at 9:11 AM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Hi,
>
> There is a WIP in the GrowErp community on a growerptest Selenium
> component, see https://issues.apache.org/jira/browse/OFBIZ-6618
>
> The commit r1709516 introduced a small change to have it working OOTB when
> you put it in hot-deploy
>
> The question is: do we agree with this way of doing and let the GrowErp
> community handles the component out of OFBiz, or should we handle it
> ourselves?
>
> Thanks for your opinions
>
> Jacques
>