You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by qingwen220 <gi...@git.apache.org> on 2017/01/19 09:14:20 UTC

[GitHub] eagle pull request #785: EAGLE-876 TopologyBaseAPIEntity comparison should c...

GitHub user qingwen220 opened a pull request:

    https://github.com/apache/eagle/pull/785

    EAGLE-876 TopologyBaseAPIEntity comparison should consider rack info

    https://issues.apache.org/jira/browse/EAGLE-876

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qingwen220/incubator-eagle EAGLE-876

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/eagle/pull/785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #785
    
----
commit cb7f41d48081e078b131419a78a3b110856f6867
Author: Zhao, Qingwen <qi...@apache.org>
Date:   2017-01-19T09:05:41Z

    Fix persisting key

commit 8205d99d075ac1ac90c43072f51f819592cb1d35
Author: Zhao, Qingwen <qi...@apache.org>
Date:   2017-01-19T09:11:04Z

    fix conflicts

commit 03cfcb139861696160a3c257b090ddb13a2ca89a
Author: Zhao, Qingwen <qi...@apache.org>
Date:   2017-01-19T09:13:05Z

    Merge branch 'EAGLE-876' of https://github.com/qingwen220/incubator-eagle into EAGLE-876

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle pull request #785: EAGLE-876 TopologyBaseAPIEntity comparison should c...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/eagle/pull/785


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle issue #785: EAGLE-876 TopologyBaseAPIEntity comparison should consider...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:

    https://github.com/apache/eagle/pull/785
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---