[jira] Commented: (WICKET-2064) Make Component.ENABLED_IN_HIERARCHY_CACHE_KEY a instance variable rather than a MetaDataKey

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669357#action_12669357 ] 

Juergen Donnerstag commented on WICKET-2064:
--------------------------------------------

why not make it transient than. It is a cache value only anyway. And though only needed for the scenario described by Igor, every component now maintains the meta data entry.

Why do we need isEnabled and isEnabledInHierarchy again? Isn't isEnabledInHierarchy all we need (=> wicket version 1.5)?

With the latest change it gets reset in detach() and internalBeforeRender(). Actually on internalBeforeRender() is needed. It seems it is reset in detach() only to make the tests work

> Make Component.ENABLED_IN_HIERARCHY_CACHE_KEY a instance variable rather than a MetaDataKey
> -------------------------------------------------------------------------------------------
>
>                 Key: WICKET-2064
>                 URL: https://issues.apache.org/jira/browse/WICKET-2064
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC1
>            Reporter: Juergen Donnerstag
>            Priority: Minor
>
> Component.ENABLED_IN_HIERARCHY_CACHE_KEY currently is a MetaDataKey which get added to each Component if isEnableInHierarchy is invoked. That basically happens all the time. In contrast the concept of MetaData has been introduced to allow rarely used data to be attached to Components (with java 1.5 in a typesafe manner). Since MetaData introduce some overhead, and for simplicity reasons, I'd suggest to convert Component.ENABLED_IN_HIERARCHY_CACHE_KEY into a Boolean instance variable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.