[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #572: nimble/gatt: Modify ble_gattc_proc_matches_conn_rx_entry

[GitBox <gi...@apache.org>]

rymanluk commented on a change in pull request #572: nimble/gatt: Modify ble_gattc_proc_matches_conn_rx_entry
URL: https://github.com/apache/mynewt-nimble/pull/572#discussion_r356292325
 
 

 ##########
 File path: nimble/host/src/ble_gattc.c
 ##########
 @@ -912,7 +912,11 @@ ble_gattc_proc_matches_conn_rx_entry(struct ble_gattc_proc *proc, void *arg)
     criteria->matching_rx_entry = ble_gattc_rx_entry_find(
         proc->op, criteria->rx_entries, criteria->num_rx_entries);
 
-    return 1;
+    if (criteria->matching_rx_entry) {
+        return 1;
+    } else {
 
 Review comment:
   Else is not needed here. Otherwise it looks good to me

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services