[jira] [Commented] (LUCENE-5813) Directory should implement Accountable

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065389#comment-14065389 ] 

Uwe Schindler commented on LUCENE-5813:
---------------------------------------

I don't think Directory itsself should implement Accountable. In my opinion, just because *some* directories consume RAM, I don't think we should make all directories implement that.

For the issue mentioned in LUCENE-5812 I think the ramBytesUsed there should simply check with instanceof if the inner directory implements accountable and then add its size to itsself. Something thats not intended to be Accountable like a purely disk based dir, should not implement it. Because otherwise a NIOFSDirectory would need to return the size of its inner ByteBuffer caches or whatever.

-1 to make Directory itsself Accountable.

> Directory should implement Accountable
> --------------------------------------
>
>                 Key: LUCENE-5813
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5813
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 4.10
>
>         Attachments: LUCENE-5813.patch
>
>
> Follow-up of LUCENE-5812.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org