You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Sascha Rodekamp (JIRA)" <ji...@apache.org> on 2010/10/11 13:53:33 UTC
[jira] Created: (OFBIZ-3984) Server Hit Bin, counterHit receive
delegator
Server Hit Bin, counterHit receive delegator
--------------------------------------------
Key: OFBIZ-3984
URL: https://issues.apache.org/jira/browse/OFBIZ-3984
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
Fix For: SVN trunk
Hi,
here is a little patch to improve the delegator call in the countHit method.
The method got the delegator name from the session and get with this delegator name over the delegator factory the delegator.
But when the delegator name is not available in the session the method crashes.
I try to get the delegator from the request, and if their is no delegator object i go the factory way.
I think it's a little bit saver to get an delegator object over this way
Have a nice day
Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-3984) Server Hit Bin, counterHit receive delegator
Posted by Sascha Rodekamp <sa...@googlemail.com>.
'Hi Pierre,
no sorry, the patch was only a little improvement between the lines :). It
don't solves the issue 3972.
Cheers
2010/10/12 Pierre Smits <pi...@gmail.com>
> Hi Sascha, Jacques
>
> Does this also resolve issue 3972?
>
> https://issues.apache.org/jira/browse/OFBIZ-3972
>
> Regards,
>
> Pierre
>
> 2010/10/11 Sascha Rodekamp (JIRA) <ji...@apache.org>
>
> >
> > [
> >
> https://issues.apache.org/jira/browse/OFBIZ-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919829#action_12919829
> ]
> >
> > Sascha Rodekamp commented on OFBIZ-3984:
> > ----------------------------------------
> >
> > That's exactly the point Jacques ;)
> > Thanks for commit!
> >
> > Have a good day
> >
> > > Server Hit Bin, counterHit receive delegator
> > > --------------------------------------------
> > >
> > > Key: OFBIZ-3984
> > > URL: https://issues.apache.org/jira/browse/OFBIZ-3984
> > > Project: OFBiz
> > > Issue Type: Improvement
> > > Components: ALL COMPONENTS
> > > Affects Versions: SVN trunk
> > > Reporter: Sascha Rodekamp
> > > Assignee: Jacques Le Roux
> > > Fix For: SVN trunk
> > >
> > > Attachments: OFBIZ-3984_serverHitBin.patch
> > >
> > >
> > > Hi,
> > > here is a little patch to improve the delegator call in the countHit
> > method.
> > > The method got the delegator name from the session and get with this
> > delegator name over the delegator factory the delegator.
> > > But when the delegator name is not available in the session the method
> > crashes.
> > > I try to get the delegator from the request, and if their is no
> delegator
> > object i go the factory way.
> > > I think it's a little bit saver to get an delegator object over this
> way
> > > Have a nice day
> > > Sascha
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
--
Sascha Rodekamp
Lynx-Consulting GmbH
Johanniskirchplatz 6
D-33615 Bielefeld
http://www.lynx.de
Re: [jira] Commented: (OFBIZ-3984) Server Hit Bin, counterHit receive delegator
Posted by Pierre Smits <pi...@gmail.com>.
Hi Sascha, Jacques
Does this also resolve issue 3972?
https://issues.apache.org/jira/browse/OFBIZ-3972
Regards,
Pierre
2010/10/11 Sascha Rodekamp (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919829#action_12919829]
>
> Sascha Rodekamp commented on OFBIZ-3984:
> ----------------------------------------
>
> That's exactly the point Jacques ;)
> Thanks for commit!
>
> Have a good day
>
> > Server Hit Bin, counterHit receive delegator
> > --------------------------------------------
> >
> > Key: OFBIZ-3984
> > URL: https://issues.apache.org/jira/browse/OFBIZ-3984
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: ALL COMPONENTS
> > Affects Versions: SVN trunk
> > Reporter: Sascha Rodekamp
> > Assignee: Jacques Le Roux
> > Fix For: SVN trunk
> >
> > Attachments: OFBIZ-3984_serverHitBin.patch
> >
> >
> > Hi,
> > here is a little patch to improve the delegator call in the countHit
> method.
> > The method got the delegator name from the session and get with this
> delegator name over the delegator factory the delegator.
> > But when the delegator name is not available in the session the method
> crashes.
> > I try to get the delegator from the request, and if their is no delegator
> object i go the factory way.
> > I think it's a little bit saver to get an delegator object over this way
> > Have a nice day
> > Sascha
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Closed: (OFBIZ-3984) Server Hit Bin, counterHit receive
delegator
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-3984.
----------------------------------
Resolution: Fixed
Assignee: Jacques Le Roux
Sascha,
Your patch is in trunk at r1021344
I wondered why you removed the _if (UtilValidate.isNotEmpty(delegatorName)) {_ check, but found that anyway _DelegatorFactory.getDelegator(_ will pick _"default"_ in such case
> Server Hit Bin, counterHit receive delegator
> --------------------------------------------
>
> Key: OFBIZ-3984
> URL: https://issues.apache.org/jira/browse/OFBIZ-3984
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3984_serverHitBin.patch
>
>
> Hi,
> here is a little patch to improve the delegator call in the countHit method.
> The method got the delegator name from the session and get with this delegator name over the delegator factory the delegator.
> But when the delegator name is not available in the session the method crashes.
> I try to get the delegator from the request, and if their is no delegator object i go the factory way.
> I think it's a little bit saver to get an delegator object over this way
> Have a nice day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3984) Server Hit Bin, counterHit receive
delegator
Posted by "Sascha Rodekamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sascha Rodekamp updated OFBIZ-3984:
-----------------------------------
Attachment: OFBIZ-3984_serverHitBin.patch
> Server Hit Bin, counterHit receive delegator
> --------------------------------------------
>
> Key: OFBIZ-3984
> URL: https://issues.apache.org/jira/browse/OFBIZ-3984
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3984_serverHitBin.patch
>
>
> Hi,
> here is a little patch to improve the delegator call in the countHit method.
> The method got the delegator name from the session and get with this delegator name over the delegator factory the delegator.
> But when the delegator name is not available in the session the method crashes.
> I try to get the delegator from the request, and if their is no delegator object i go the factory way.
> I think it's a little bit saver to get an delegator object over this way
> Have a nice day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3984) Server Hit Bin, counterHit receive
delegator
Posted by "Sascha Rodekamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919829#action_12919829 ]
Sascha Rodekamp commented on OFBIZ-3984:
----------------------------------------
That's exactly the point Jacques ;)
Thanks for commit!
Have a good day
> Server Hit Bin, counterHit receive delegator
> --------------------------------------------
>
> Key: OFBIZ-3984
> URL: https://issues.apache.org/jira/browse/OFBIZ-3984
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3984_serverHitBin.patch
>
>
> Hi,
> here is a little patch to improve the delegator call in the countHit method.
> The method got the delegator name from the session and get with this delegator name over the delegator factory the delegator.
> But when the delegator name is not available in the session the method crashes.
> I try to get the delegator from the request, and if their is no delegator object i go the factory way.
> I think it's a little bit saver to get an delegator object over this way
> Have a nice day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.