[jira] [Closed] (DAFFODIL-2347) TDML Runner no longer marks "not compatible with implementation" tests as skipped

["Dave Thompson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DAFFODIL-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Thompson closed DAFFODIL-2347.
-----------------------------------

This is not a daffodil issue.

> TDML Runner no longer marks "not compatible with implementation" tests as skipped
> ---------------------------------------------------------------------------------
>
>                 Key: DAFFODIL-2347
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2347
>             Project: Daffodil
>          Issue Type: Bug
>          Components: TDML Runner
>    Affects Versions: 2.6.0
>            Reporter: Steve Lawrence
>            Priority: Major
>             Fix For: 3.0.0
>
>
> Running DFDLSchemas/csv tests with the IBM implementation results in 2 test failures with the error:
> {code}
> Test com.tresys.csv.TestCSV.test_csv_test_2 failed: org.apache.daffodil.tdml.TDMLTestNotCompatibleException: (Implementation: ibm) Test 'csv_test_2' not compatible with implementation.
> {code}
> When JUnit is on the classpath, the TDML runner should throw an {{org.junit.AssumptionViolatedException}} so that the test is just marked as skipped by Junit (see {{def testNotCompatible}} in {{TDMLRunner.scala}}). But instead it is just throwing a TDMLTestNotCompatiableException.
> I have confirmed that when running the tests the Junit jar is on the classpath, but the exception class does not exist in the jnit jar. Instead, there is only {{org.junit.internal.AssumptionViolatedException}}. Perhaps we updated junit and the new version only has the internal exception? Or maybe the non-internal version is only available in newer versions of Junit4 and we need to upgrade?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)