You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "junegunn (via GitHub)" <gi...@apache.org> on 2026/04/30 06:21:37 UTC

[PR] Backport "HBASE-30101 Move login() before RpcServer construction (#8122)" to branch-2 [hbase]

junegunn opened a new pull request, #8173:
URL: https://github.com/apache/hbase/pull/8173

   Summary of resolution:
   - `HBaseServerBase.java` doesn't exist in `branch-2`; the constructor logic lives directly in `HRegionServer`. Kept the file deleted with `git rm`.
   - Adapted the master-branch changes (originally in `HBaseServerBase`) into `HRegionServer`:
     - Reordered the constructor: resolve hostname → ZK login → server login → `createRpcServices()`.
     - Added `resolveHostName()` helper using `DNS.getHostname(conf, getDNSServerType())`.
     - Added `getDNSServerType()` returning `REGIONSERVER` (HMaster's `MASTER` override was already in the staged hunk).
     - Changed the `UNSAFE_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY` branch in `getUseThisHostnameInstead` to use `DNS.getHostname` instead of `rpcServices.isa.getHostName()`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Backport "HBASE-30101 Move login() before RpcServer construction (#8122)" to branch-2 [hbase]

Posted by "junegunn (via GitHub)" <gi...@apache.org>.

junegunn merged PR #8173:
URL: https://github.com/apache/hbase/pull/8173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org