[GitHub] [incubator-pinot] kishoreg commented on issue #4796: [In Progress] Pinot Spark

[GitBox <gi...@apache.org>]

kishoreg commented on issue #4796: [In Progress] Pinot Spark
URL: https://github.com/apache/incubator-pinot/pull/4796#issuecomment-550726704
 
 
   > I might be missing something, but a lot of these classes look exactly the same as classes we have for hadoop - eg: util classes like JobConfigConstants, ControllerRestApi, etc. Are they meant to be different or is the future idea to move these to a neutral module and import them into both spark and hadoop?
   
   For now, it's better to copy those classes instead of the spark module depending on the Hadoop module. Ideally, we need to create a base-module and move all common code to that module. Let's create an issue and address it when we refactor pinot ingestion modules. https://github.com/apache/incubator-pinot/issues/4731

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org