[jira] [Commented] (LUCENE-4124) factor ByteBufferIndexInput out of MMapDirectory

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291899#comment-13291899 ] 

Uwe Schindler commented on LUCENE-4124:
---------------------------------------

Thanks for assigning me. Patch looks good as first step. The hashcode and equals in the (now abstract) base class must be final. This was not done before, as class on itself was final.
                
> factor ByteBufferIndexInput out of MMapDirectory
> ------------------------------------------------
>
>                 Key: LUCENE-4124
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4124
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/store
>            Reporter: Robert Muir
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-4124.patch
>
>
> I think we should factor a ByteBufferIndexInput out of MMapDir, leaving only the mmap/unmapping in mmapdir.
> Its a cleaner separation and would allow it to be used for other purposes (e.g. direct or array-backed buffers)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org