You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2023/03/17 23:45:31 UTC
Review Request 74350: RANGER-4136: Incorrect processing of tag-deltas by RangerTagEnricher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74350/
-----------------------------------------------------------
Review request for ranger, madhan and Madhan Neethiraj.
Bugs: RANGER-4136
https://issues.apache.org/jira/browse/RANGER-4136
Repository: ranger
Description
-------
Ranger supports incremental tag downloads when configured. When a mapping for a service-resource is changed, the tag download request provides only the updated service-resource. RangerTagEnricher is expected to remove the existing service-resource and the associated tags from its cache and add it back with updated associated tags.
Current code does not remove the existing service-resource and its associated tags correctly leading to incorrect tags to be retrieved for the service-resource.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java efb885a74
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceEvaluatorsRetriever.java dfe591c59
Diff: https://reviews.apache.org/r/74350/diff/1/
Testing
-------
Compiled and ran unit tests. Tested and verified in a live cluster.
Thanks,
Abhay Kulkarni
Re: Review Request 74350: RANGER-4136: Incorrect processing of tag-deltas by RangerTagEnricher
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74350/#review225292
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 22, 2023, 4:23 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74350/
> -----------------------------------------------------------
>
> (Updated March 22, 2023, 4:23 p.m.)
>
>
> Review request for ranger, madhan and Madhan Neethiraj.
>
>
> Bugs: RANGER-4136
> https://issues.apache.org/jira/browse/RANGER-4136
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports incremental tag downloads when configured. When a mapping for a service-resource is changed, the tag download request provides only the updated service-resource. RangerTagEnricher is expected to remove the existing service-resource and the associated tags from its cache and add it back with updated associated tags.
>
> Current code does not remove the existing service-resource and its associated tags correctly leading to incorrect tags to be retrieved for the service-resource.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java efb885a74
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java fb7bcaada
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java 80d27e8e8
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceEvaluatorsRetriever.java dfe591c59
>
>
> Diff: https://reviews.apache.org/r/74350/diff/2/
>
>
> Testing
> -------
>
> Compiled and ran unit tests. Tested and verified in a live cluster.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 74350: RANGER-4136: Incorrect processing of tag-deltas by RangerTagEnricher
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74350/
-----------------------------------------------------------
(Updated March 22, 2023, 4:23 p.m.)
Review request for ranger, madhan and Madhan Neethiraj.
Bugs: RANGER-4136
https://issues.apache.org/jira/browse/RANGER-4136
Repository: ranger
Description
-------
Ranger supports incremental tag downloads when configured. When a mapping for a service-resource is changed, the tag download request provides only the updated service-resource. RangerTagEnricher is expected to remove the existing service-resource and the associated tags from its cache and add it back with updated associated tags.
Current code does not remove the existing service-resource and its associated tags correctly leading to incorrect tags to be retrieved for the service-resource.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java efb885a74
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java fb7bcaada
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java 80d27e8e8
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceEvaluatorsRetriever.java dfe591c59
Diff: https://reviews.apache.org/r/74350/diff/2/
Changes: https://reviews.apache.org/r/74350/diff/1-2/
Testing
-------
Compiled and ran unit tests. Tested and verified in a live cluster.
Thanks,
Abhay Kulkarni