You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/30 21:04:24 UTC

[GitHub] [commons-lang] kinow commented on issue #506: LANG-1530 another method like formatDurationWords with

kinow commented on issue #506: LANG-1530 another method like formatDurationWords with 
URL: https://github.com/apache/commons-lang/pull/506#issuecomment-606248887
 
 
   > Hi All,
   > 
   > Before we make this class heavier, let's step back and consider what Java 8's own [Duration](https://docs.oracle.com/javase/8/docs/api/java/time/Duration.html) and [Period](https://docs.oracle.com/javase/8/docs/api/java/time/Period.html) classes have to offer and how this class should interact/interface with these.
   
   +1
   
   I had a quick look at the code, but didn't want to prepare a review before checking if we run the risk of needing one more test to display time zone with micro seconds, and yet more methods for other things.
   
   Good idea on looking at the SDK classes first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services