You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by "laxmanprabhu (via GitHub)" <gi...@apache.org> on 2023/04/17 23:10:21 UTC

[GitHub] [zookeeper] laxmanprabhu commented on pull request #1257: ZOOKEEPER-3652: Synchronize ClientCnxn outgoing queue flush on a stable internal value

laxmanprabhu commented on PR #1257:
URL: https://github.com/apache/zookeeper/pull/1257#issuecomment-1512214435

   The `cleanUp` method is also called by `cleanAndNotifyState()`. Is there a reason why `cleanUp` method call isn't synchronized in this code path as well.
   
   When `cleanAndNotifyState()` calls cleanUp, the outgoingQueue is iterated without any synchronization. During this stage more callers can queue requests to the outgoingQueue. This causes the cleanUp method to keep iterating and possible take long time to complete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org