You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2019/12/11 10:35:06 UTC

[GitHub] [incubator-pagespeed-mod] oschaaf commented on a change in pull request #1969: Integration of envoy fetcher in pagespeed

oschaaf commented on a change in pull request #1969: Integration of envoy fetcher in pagespeed
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1969#discussion_r356505679
 
 

 ##########
 File path: pagespeed/envoy/cluster.yaml
 ##########
 @@ -0,0 +1,41 @@
+static_resources:
 
 Review comment:
   Instead of this file, can we use the api's to set up the cluster?
   for an example, see https://github.com/envoyproxy/nighthawk/blob/master/source/client/process_impl.cc#L232

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services