[jira] [Commented] (THRIFT-2219) Thrift gem fails to build on OS X Mavericks with 1.9.3 rubies

["Jake Farrell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863871#comment-13863871 ] 

Jake Farrell commented on THRIFT-2219:
--------------------------------------

removing the extern is not the correct approach due to systems that may have strlcpy already defined, and using _FORTIFY_SOURCE=0 in the cpp flags is a hacky workaround. instead i would like to see us use the __has_builtin macro to check and see if strlcpy is a builtin and if not then include the extern strlcopy

#if !__has_builtin(strlcpy)
extern size_t strlcpy(char *, const char *, size_t);
#endif

tested on mav and verifying this works on centos, ubuntu and and windows and then will commit

> Thrift gem fails to build on OS X Mavericks with 1.9.3 rubies
> -------------------------------------------------------------
>
>                 Key: THRIFT-2219
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2219
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.9.1
>         Environment: OS X Mavericks (GM), ruby 1.9.3-p448 built with rbenv/ruby-build
>            Reporter: Chris Anderson
>             Fix For: 0.9.2
>
>         Attachments: thrift-2219-no-strlcpy-redeclaration_2.patch
>
>
> (Preface, this issue is for the unreleased OS X Mavericks, so understand if it's not fixable now, just wanted to bring it up.)
> I'm unable install the 0.9.1 thrift gem on my GM OS X Mavericks system with ruby 1.9.3-p448. I get the error `extconf.rb:25: Use RbConfig instead of obsolete and deprecated Config.` along with some strlcopy errors. 
> Strack trace is at (https://gist.github.com/chrismanderson/6834809)
> Oddly, I CAN install the 0.9.1 gem with both 2.0.0-p247 and ree-1.8.7-2011.12. I also tried 1.9.3-p194 and p429 and got the same error.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)