You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/02/23 17:28:36 UTC

[Impala-ASF-CR](2.x) IMPALA-6219: actually turn on AES-GCM 

Hello Alex Behm, Impala Public Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9421

to review the following change.


Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................

IMPALA-6219: actually turn on AES-GCM

There was a typo that prevented it from matching the output of cpuinfo
correctly.

Testing:
Manually verified that impalad.INFO contains the expected hardware
flags:

  Hardware Supports:
    ssse3
    sse4_1
    sse4_2
    popcnt
    avx
    avx2
    pclmulqdq

Added temporary logging to verify that openssl-util-test and impala with
--disk_spill_encryption=true were going down the expected code path.

Added permanent logging at startup to report the default mode.

Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Reviewed-on: http://gerrit.cloudera.org:8080/9386
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/common/init.cc
M be/src/util/cpu-info.cc
M be/src/util/openssl-util.cc
M be/src/util/openssl-util.h
4 files changed, 16 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/9421/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9421
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR](2.x) IMPALA-6219: actually turn on AES-GCM

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9421 )

Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................


Patch Set 1: Verified+1

Tested with https://gerrit.cloudera.org/#/c/9417/


-- 
To view, visit http://gerrit.cloudera.org:8080/9421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9421
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 22:50:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6219: actually turn on AES-GCM

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9421 )

Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................


Patch Set 1: Code-Review+2

Clean pick (just uploading to test in batch)


-- 
To view, visit http://gerrit.cloudera.org:8080/9421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9421
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 17:49:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6219: actually turn on AES-GCM

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9421 )

Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................

IMPALA-6219: actually turn on AES-GCM

There was a typo that prevented it from matching the output of cpuinfo
correctly.

Testing:
Manually verified that impalad.INFO contains the expected hardware
flags:

  Hardware Supports:
    ssse3
    sse4_1
    sse4_2
    popcnt
    avx
    avx2
    pclmulqdq

Added temporary logging to verify that openssl-util-test and impala with
--disk_spill_encryption=true were going down the expected code path.

Added permanent logging at startup to report the default mode.

Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Reviewed-on: http://gerrit.cloudera.org:8080/9386
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/9421
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M be/src/common/init.cc
M be/src/util/cpu-info.cc
M be/src/util/openssl-util.cc
M be/src/util/openssl-util.h
4 files changed, 16 insertions(+), 14 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9421
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>