[jira] [Commented] (OFBIZ-5251) respect https attribute in ofbizUrl

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787591#comment-13787591 ] 

Jacques Le Roux commented on OFBIZ-5251:
----------------------------------------

I wonder if you are addressin the right issue. Your changes would only bypass enableHttps which is not wanted (possibly sets in WebSite or url.properties)

Could you please elaborate?
    # What you did (including detailed steps to reproduce if necessary)
    # What you expected to happen
    # What actually happened
    # If possible provide an URL on demo as an example

Maybe we have rather an issue with request.isSecure()?
[The JavaDoc is not verbose nor quite clear|http://docs.oracle.com/javaee/6/api/javax/servlet/ServletRequest.html#isSecure%28%29].
[This gives a better detailled information|http://stackoverflow.com/questions/8200853/how-can-i-know-if-the-request-to-the-servlet-was-executed-using-http-or-https#answer-8208910].


> respect https attribute in ofbizUrl
> -----------------------------------
>
>                 Key: OFBIZ-5251
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5251
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: greg jocher
>            Priority: Trivial
>              Labels: PatchAvailable
>         Attachments: RequestHandler.java.patch
>
>
> We think, the ofbizUrl transform should return a https link if the controller sets https=true for a request. Currently it returns a http link if the template is requested with http.



--
This message was sent by Atlassian JIRA
(v6.1#6144)