You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/04 10:32:54 UTC

[GitHub] codecov-io commented on issue #3640: Fix minor log bug in BaseSingleTreeBuilder

codecov-io commented on issue #3640: Fix minor log bug in BaseSingleTreeBuilder
URL: https://github.com/apache/incubator-pinot/pull/3640#issuecomment-451408578
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3640?src=pr&el=h1) Report
   > Merging [#3640](https://codecov.io/gh/apache/incubator-pinot/pull/3640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/ef32663fe45003c17272e24057e76cfe830fe8a3?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3640/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3640?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3640      +/-   ##
   ============================================
   + Coverage     70.68%   70.69%   +<.01%     
     Complexity        4        4              
   ============================================
     Files          1012     1012              
     Lines         46454    46454              
     Branches       6212     6212              
   ============================================
   + Hits          32838    32842       +4     
   + Misses        11461    11457       -4     
     Partials       2155     2155
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3640?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ore/startree/v2/builder/BaseSingleTreeBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3N0YXJ0cmVlL3YyL2J1aWxkZXIvQmFzZVNpbmdsZVRyZWVCdWlsZGVyLmphdmE=) | `95.19% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...in/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9WYWxpZFNlZ21lbnRQcnVuZXIuamF2YQ==) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
   | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
   | [...lix/EmptyBrokerOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L0VtcHR5QnJva2VyT25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `86.66% <0%> (-13.34%)` | `0% <0%> (ø)` | |
   | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `86.66% <0%> (-6.67%)` | `0% <0%> (ø)` | |
   | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL01WU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `63.63% <0%> (-3.04%)` | `0% <0%> (ø)` | |
   | [.../impl/dictionary/BaseOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9CYXNlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `81.03% <0%> (-2.88%)` | `0% <0%> (ø)` | |
   | [...edin/pinot/common/metadata/ZKMetadataProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRhZGF0YS9aS01ldGFkYXRhUHJvdmlkZXIuamF2YQ==) | `68.94% <0%> (-1.25%)` | `0% <0%> (ø)` | |
   | [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVhbHRpbWUvUGlub3RSZWFsdGltZVNlZ21lbnRNYW5hZ2VyLmphdmE=) | `72.77% <0%> (-1.05%)` | `0% <0%> (ø)` | |
   | [...inot/core/operator/docidsets/AndBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkc2V0cy9BbmRCbG9ja0RvY0lkU2V0LmphdmE=) | `56.94% <0%> (-0.7%)` | `0% <0%> (ø)` | |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-pinot/pull/3640/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3640?src=pr&el=footer). Last update [ef32663...39abb5a](https://codecov.io/gh/apache/incubator-pinot/pull/3640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org