[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

[GitBox <gi...@apache.org>]

mqliang commented on a change in pull request #6710:
URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603021060



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java
##########
@@ -45,9 +51,140 @@
   String NUM_RESIZES_METADATA_KEY = "numResizes";
   String RESIZE_TIME_MS_METADATA_KEY = "resizeTimeMs";
   String EXECUTION_THREAD_CPU_TIME_NS_METADATA_KEY = "executionThreadCpuTimeNs";
+  String RESPONSE_SERIALIZATION_CPU_TIME_NS_METADATA_KEY = "responseSerializationCpuTimeNs";
+
+  /* The TrailerKeys is used in V3, where we put all metadata as part of trailer and use enum keys as metadata keys.
+   * Currently all trailer keys are metadata keys, but in future we may add trailer key which is not a metadata key.
+   *
+   * NOTE:
+   * if you add a new key in TrailerKeys enum
+   *  - you need add it's corresponding string to TrailerKeyToMetadataKeyMap/MetadataKeyToTrailerKeyMap also.
+   *  - if it happen to be a metadata key, add it into MetadataKeys also.
+   *  - if it has a long/int type value, add it into LongValueTrailerKeys/LongValueTrailerKeys also.
+   *
+   * ATTENTION:
+   *  - Always add new key to the end of enum.
+   *  - Don't remove existing keys.
+   *  Otherwise, backward compatibility will be broken.
+   */
+  enum TrailerKeys {
+    TABLE_KEY, // NOTE: this key is only used in PrioritySchedulerTest

Review comment:
       done

##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java
##########
@@ -45,9 +51,140 @@
   String NUM_RESIZES_METADATA_KEY = "numResizes";
   String RESIZE_TIME_MS_METADATA_KEY = "resizeTimeMs";
   String EXECUTION_THREAD_CPU_TIME_NS_METADATA_KEY = "executionThreadCpuTimeNs";
+  String RESPONSE_SERIALIZATION_CPU_TIME_NS_METADATA_KEY = "responseSerializationCpuTimeNs";

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org