You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/06/10 23:20:13 UTC
[GitHub] [incubator-mxnet] mseth10 opened a new pull request #20342: [WIP] [v1.x] Use ArmPL as BLAS for MXNet
mseth10 opened a new pull request #20342:
URL: https://github.com/apache/incubator-mxnet/pull/20342
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #20342: [v1.x] Use ArmPL as BLAS for MXNet AArch64 wheels
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #20342:
URL: https://github.com/apache/incubator-mxnet/pull/20342#discussion_r651334014
##########
File path: src/operator/c_lapack_api.h
##########
@@ -70,8 +70,38 @@
using namespace mshadow;
-// Will cause clash with MKL fortran layer headers
+#define XSTR(x) STR(x)
+#define STR(x) #x
+
+#pragma message "The value of MSHADOW_USE_MKL: " XSTR(MSHADOW_USE_MKL)
Review comment:
what are theses `#pragma message` for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #20342: [v1.x] Use ArmPL as BLAS for MXNet AArch64 wheels
Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #20342:
URL: https://github.com/apache/incubator-mxnet/pull/20342#discussion_r651370471
##########
File path: tools/staticbuild/build.sh
##########
@@ -59,7 +59,11 @@ else
export PKG_CONFIG_PATH=$DEPS_PATH/lib/pkgconfig:$DEPS_PATH/lib64/pkgconfig:$DEPS_PATH/lib/x86_64-linux-gnu/pkgconfig:$PKG_CONFIG_PATH
fi
export FC="gfortran"
-export CPATH=$DEPS_PATH/include:$CPATH
+if [[ $ARCH == 'aarch64' ]]; then
+ export CPATH=/opt/arm/armpl_21.0_gcc-8.2/include_lp64_mp:$CPATH
Review comment:
we can ask users to specifically install `armpl_21.0_gcc-8.2` before installing mxnet wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #20342: [v1.x] Use ArmPL as BLAS for MXNet AArch64 wheels
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #20342:
URL: https://github.com/apache/incubator-mxnet/pull/20342#discussion_r651362257
##########
File path: tools/staticbuild/build.sh
##########
@@ -59,7 +59,11 @@ else
export PKG_CONFIG_PATH=$DEPS_PATH/lib/pkgconfig:$DEPS_PATH/lib64/pkgconfig:$DEPS_PATH/lib/x86_64-linux-gnu/pkgconfig:$PKG_CONFIG_PATH
fi
export FC="gfortran"
-export CPATH=$DEPS_PATH/include:$CPATH
+if [[ $ARCH == 'aarch64' ]]; then
+ export CPATH=/opt/arm/armpl_21.0_gcc-8.2/include_lp64_mp:$CPATH
Review comment:
If the user installed a different armpl package then this will not work, is there a way to automatically detect the armpl path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #20342: [v1.x] Use ArmPL as BLAS for MXNet AArch64 wheels
Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #20342:
URL: https://github.com/apache/incubator-mxnet/pull/20342#discussion_r651336115
##########
File path: src/operator/c_lapack_api.h
##########
@@ -70,8 +70,38 @@
using namespace mshadow;
-// Will cause clash with MKL fortran layer headers
+#define XSTR(x) STR(x)
+#define STR(x) #x
+
+#pragma message "The value of MSHADOW_USE_MKL: " XSTR(MSHADOW_USE_MKL)
Review comment:
these I put to debug the error I am seeing in amalgamation builds.. but they dont help, so removing them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20342: [WIP] [v1.x] Use ArmPL as BLAS for MXNet
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20342:
URL: https://github.com/apache/incubator-mxnet/pull/20342#issuecomment-859149097
Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, sanity, unix-cpu, windows-cpu, centos-gpu, windows-gpu, edge, website, miscellaneous, clang, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 merged pull request #20342: [v1.x] Use ArmPL as BLAS for MXNet AArch64 wheels
Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #20342:
URL: https://github.com/apache/incubator-mxnet/pull/20342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #20342: [v1.x] Use ArmPL as BLAS for MXNet AArch64 wheels
Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #20342:
URL: https://github.com/apache/incubator-mxnet/pull/20342#discussion_r651363271
##########
File path: tools/staticbuild/build.sh
##########
@@ -59,7 +59,11 @@ else
export PKG_CONFIG_PATH=$DEPS_PATH/lib/pkgconfig:$DEPS_PATH/lib64/pkgconfig:$DEPS_PATH/lib/x86_64-linux-gnu/pkgconfig:$PKG_CONFIG_PATH
fi
export FC="gfortran"
-export CPATH=$DEPS_PATH/include:$CPATH
+if [[ $ARCH == 'aarch64' ]]; then
+ export CPATH=/opt/arm/armpl_21.0_gcc-8.2/include_lp64_mp:$CPATH
Review comment:
does it work with other armpl versions? didn't we see an error when we were using gcc-10 armpl?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org