You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/16 09:35:32 UTC

[GitHub] [tvm] lhutton1 opened a new pull request #9514: [microNPU] Adding rounding mode attribute to operators

lhutton1 opened a new pull request #9514:
URL: https://github.com/apache/tvm/pull/9514


   Allows rounding mode to be specified for each supported operator. By default "TFL" is used, which matches that of the behavior of TFLite. Other rounding mode options include "NATURAL" which rounds to the nearest value and "TRUNCATE" which rounds towards zero.
   
   cc @ekalda @manupa-arm @NicolaLancellotti @dchauhan-arm @mbaret 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] NicolaLancellotti commented on a change in pull request #9514: [microNPU] Adding rounding mode attribute to operators

Posted by GitBox <gi...@apache.org>.
NicolaLancellotti commented on a change in pull request #9514:
URL: https://github.com/apache/tvm/pull/9514#discussion_r750215632



##########
File path: python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
##########
@@ -617,6 +621,21 @@ def _create_npu_resampling_mode(
     return mode_map[mode]
 
 
+def _create_npu_rounding_mode(
+    mode,
+):

Review comment:
       Can you add the argument and the return type hints?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] lhutton1 commented on pull request #9514: [microNPU] Adding rounding mode attribute to operators

Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #9514:
URL: https://github.com/apache/tvm/pull/9514#issuecomment-971407341


   Thanks @NicolaLancellotti, @manupa-arm for the reviews! Yes, I think it would be quite difficult to test each rounding scheme fully. The implementation of MEAN would rely on all three schemes being used, so this would be a good E2E test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] manupa-arm commented on pull request #9514: [microNPU] Adding rounding mode attribute to operators

Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9514:
URL: https://github.com/apache/tvm/pull/9514#issuecomment-971549073


   Thanks @lhutton1 @NicolaLancellotti . This is merged now!.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] manupa-arm merged pull request #9514: [microNPU] Adding rounding mode attribute to operators

Posted by GitBox <gi...@apache.org>.
manupa-arm merged pull request #9514:
URL: https://github.com/apache/tvm/pull/9514


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] lhutton1 commented on a change in pull request #9514: [microNPU] Adding rounding mode attribute to operators

Posted by GitBox <gi...@apache.org>.
lhutton1 commented on a change in pull request #9514:
URL: https://github.com/apache/tvm/pull/9514#discussion_r750529858



##########
File path: python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
##########
@@ -617,6 +621,21 @@ def _create_npu_resampling_mode(
     return mode_map[mode]
 
 
+def _create_npu_rounding_mode(
+    mode,
+):

Review comment:
       woops




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org