You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/13 03:43:37 UTC
[GitHub] [tvm] tk1012 opened a new pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
tk1012 opened a new pull request #8034:
URL: https://github.com/apache/tvm/pull/8034
This PR fixes a bug in `EdgeTPURuntime::Init()`, in which `flatBuffersBuffer_` is not used for initializing `FlatBufferModel`.
This bug causes a SEGV during `TFLiteRuntime::Invoke()`.
This PR also includes a small modification on tests/python/contrib/test_edgetpu_runtime.py to clarify we should pass "edge_tpu" for `tflite_runtime.create()` when using edgetpus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tk1012 commented on pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
Posted by GitBox <gi...@apache.org>.
tk1012 commented on pull request #8034:
URL: https://github.com/apache/tvm/pull/8034#issuecomment-841020843
make a tiny fix for passing pylint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tk1012 commented on pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
Posted by GitBox <gi...@apache.org>.
tk1012 commented on pull request #8034:
URL: https://github.com/apache/tvm/pull/8034#issuecomment-840980764
Thank you @tmoreau89 for feedback.
I add a comment for showing the test script was tested on TF v2.4.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tk1012 commented on pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
Posted by GitBox <gi...@apache.org>.
tk1012 commented on pull request #8034:
URL: https://github.com/apache/tvm/pull/8034#issuecomment-840948378
Thank @tmoreau89 for a quick reply.
I tested two versions of tensorflow / tflite.
+ the latest commit hash when I tested (https://github.com/tensorflow/tensorflow/tree/c523f23149c437ae0a5b57527897b6f8355fb4b3)
+ v2.4.1 (https://github.com/tensorflow/tensorflow/tree/9a2545aecc498e7a5e8bf5d63c47af59e1550111)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 edited a comment on pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
Posted by GitBox <gi...@apache.org>.
tmoreau89 edited a comment on pull request #8034:
URL: https://github.com/apache/tvm/pull/8034#issuecomment-840755027
Thank you @tk1012 ! Which version of tensorflow / tflite was this tested on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #8034:
URL: https://github.com/apache/tvm/pull/8034#issuecomment-840960141
Could you add a comment in the test script which versions of TF it's dependent on? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #8034:
URL: https://github.com/apache/tvm/pull/8034#issuecomment-840755027
Thank you @tk1012 ! Which version of tflite was this tested on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tk1012 commented on pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
Posted by GitBox <gi...@apache.org>.
tk1012 commented on pull request #8034:
URL: https://github.com/apache/tvm/pull/8034#issuecomment-840273196
According to https://github.com/apache/tvm/pull/4698, @tmoreau89 , @ZihengJiang, @tqchen for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 merged pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #8034:
URL: https://github.com/apache/tvm/pull/8034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #8034: [Fix][Runtime] Use flatBuffersBuffer_ in EdgeTPURuntime::Init()
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #8034:
URL: https://github.com/apache/tvm/pull/8034#issuecomment-841461458
Thank you @tk1012 the PR has been merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org