You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/05 17:02:39 UTC
[GitHub] [druid] vogievetsky opened a new pull request #11203: Web console: add more query fixing auto suggestions
vogievetsky opened a new pull request #11203:
URL: https://github.com/apache/druid/pull/11203
This PR improves the auto suggestions for queries and just makes the query experience just a little bit better.
It also improves query intelligence when fractional indexes are used (like `GROUP BY 1.5`) which is strange but supported by Druid/Calcite - who am I to judge?
This PR has:
- [x] been self-reviewed.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #11203: Web console: add more query fixing auto suggestions
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11203:
URL: https://github.com/apache/druid/pull/11203#issuecomment-854858435
Thank you for the review and the help with figuring out POM files @clintropolis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #11203: Web console: add more query fixing auto suggestions
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #11203:
URL: https://github.com/apache/druid/pull/11203#discussion_r641782760
##########
File path: web-console/package.json
##########
@@ -54,6 +51,13 @@
"check-licenses": "license-checker --production --onlyAllow 'Apache-1.1;Apache-2.0;BSD-2-Clause;BSD-3-Clause;0BSD;MIT;CC0-1.0' --summary",
"start": "webpack serve --hot --open"
},
+ "engines": {
+ "node": ">=14"
Review comment:
what does this stuff mean? do we need to update the nodejs version we use to build this when using maven? https://github.com/apache/druid/blob/master/pom.xml#L103 (this is also used by website builds afaik)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #11203: Web console: add more query fixing auto suggestions
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #11203:
URL: https://github.com/apache/druid/pull/11203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a change in pull request #11203: Web console: add more query fixing auto suggestions
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #11203:
URL: https://github.com/apache/druid/pull/11203#discussion_r643283345
##########
File path: web-console/package.json
##########
@@ -54,6 +51,13 @@
"check-licenses": "license-checker --production --onlyAllow 'Apache-1.1;Apache-2.0;BSD-2-Clause;BSD-3-Clause;0BSD;MIT;CC0-1.0' --summary",
"start": "webpack serve --hot --open"
},
+ "engines": {
+ "node": ">=14"
Review comment:
This is too complex for me to think about... with the website interaction that is. I added it to inform the local dev tools. I think if you are developing on the web console locally you really want node > 10 for some of the dev dependancies. I will remove the engines entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org