[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #991: Change server redis version string

[GitBox <gi...@apache.org>]

git-hulk commented on code in PR #991:
URL: https://github.com/apache/incubator-kvrocks/pull/991#discussion_r995951259


##########
src/server.cc:
##########
@@ -780,7 +780,7 @@ void Server::GetServerInfo(std::string *info) {
   }
   time(&now);
   string_stream << "# Server\r\n";
-  string_stream << "version:" << VERSION << "\r\n";
+  string_stream << "redis_version:" << VERSION << "\r\n";

Review Comment:
   Yes, Kvrocks is Redis protocol compatible but should NOT change its version to Redis directly. 
   
   But we can discuss how to work around this scenario. From my proposition, I think you can fork and modify your repository and then have a test. If all go smoothly, then we can see if possible to compatible this on `spark-redis`. What do you think? @juancrescente 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org