You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2022/06/16 05:55:42 UTC

[GitHub] [carbondata] Indhumathi27 commented on a diff in pull request #4279: [WIP] Drop Index Fails after TABLE RENAME

Indhumathi27 commented on code in PR #4279:
URL: https://github.com/apache/carbondata/pull/4279#discussion_r898718177


##########
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java:
##########
@@ -1138,11 +1138,9 @@ public void readFields(DataInput in) throws IOException {
   }
 
   private void deserializeIndexMetadata() throws IOException {
-    if (indexMetadata == null) {
-      String indexMeta = tableInfo.getFactTable().getTableProperties().get(getTableId());
-      if (null != indexMeta) {
-        indexMetadata = IndexMetadata.deserialize(indexMeta);
-      }
+    String indexMeta = tableInfo.getFactTable().getTableProperties().get(getTableId());

Review Comment:
   deserializing metadata everytime will impact the performance, so please reload the index table cache  during Alter rename operation itself



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org