You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/05 23:45:33 UTC

[kudu-CR] subprocess: add server metric for queue size

Hello Adar Dembo, Hao Hao,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15375

to review the following change.


Change subject: subprocess: add server metric for queue size
......................................................................

subprocess: add server metric for queue size

Unlike the Java in/outbound queues, the C++ queues are measured in
bytes. This exposes histogram metrics for the sizes of the inbound and
outbound queue at Put-time.

This also adds a method to get the logical size of a blocking queue.

Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
---
M src/kudu/ranger/ranger_client.cc
M src/kudu/subprocess/echo_subprocess.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy-test.cc
M src/kudu/util/blocking_queue-test.cc
M src/kudu/util/blocking_queue.h
7 files changed, 114 insertions(+), 52 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/15375/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
Gerrit-Change-Number: 15375
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>

[kudu-CR] subprocess: add server metric for queue size

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 )

Change subject: subprocess: add server metric for queue size
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15375/1/src/kudu/util/blocking_queue.h
File src/kudu/util/blocking_queue.h:

http://gerrit.cloudera.org:8080/#/c/15375/1/src/kudu/util/blocking_queue.h@277
PS1, Line 277:   const size_t max_size_;
> Could you declare this const?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
Gerrit-Change-Number: 15375
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 01:13:48 +0000
Gerrit-HasComments: Yes

[kudu-CR] subprocess: add server metric for queue size

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 )

Change subject: subprocess: add server metric for queue size
......................................................................


Patch Set 2: Verified+1

Flaky: HmsSentryConfigurations/MasterFailoverTest.TestMasterPermanentFailure


-- 
To view, visit http://gerrit.cloudera.org:8080/15375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
Gerrit-Change-Number: 15375
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 02:03:42 +0000
Gerrit-HasComments: No

[kudu-CR] subprocess: add server metric for queue size

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 )

Change subject: subprocess: add server metric for queue size
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
Gerrit-Change-Number: 15375
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 01:15:15 +0000
Gerrit-HasComments: No

[kudu-CR] subprocess: add server metric for queue size

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15375

to look at the new patch set (#2).

Change subject: subprocess: add server metric for queue size
......................................................................

subprocess: add server metric for queue size

Unlike the Java in/outbound queues, the C++ queues are measured in
bytes. This exposes histogram metrics for the sizes of the inbound and
outbound queue at Put-time.

This also adds a method to get the logical size of a blocking queue.

Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
---
M src/kudu/ranger/ranger_client.cc
M src/kudu/subprocess/echo_subprocess.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy-test.cc
M src/kudu/util/blocking_queue-test.cc
M src/kudu/util/blocking_queue.h
7 files changed, 115 insertions(+), 53 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/15375/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
Gerrit-Change-Number: 15375
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] subprocess: add server metric for queue size

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15375 )

Change subject: subprocess: add server metric for queue size
......................................................................

subprocess: add server metric for queue size

Unlike the Java in/outbound queues, the C++ queues are measured in
bytes. This exposes histogram metrics for the sizes of the inbound and
outbound queue at Put-time.

This also adds a method to get the logical size of a blocking queue.

Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
Reviewed-on: http://gerrit.cloudera.org:8080/15375
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/ranger/ranger_client.cc
M src/kudu/subprocess/echo_subprocess.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy-test.cc
M src/kudu/util/blocking_queue-test.cc
M src/kudu/util/blocking_queue.h
7 files changed, 115 insertions(+), 53 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Andrew Wong: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
Gerrit-Change-Number: 15375
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] subprocess: add server metric for queue size

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 )

Change subject: subprocess: add server metric for queue size
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15375/1/src/kudu/util/blocking_queue.h
File src/kudu/util/blocking_queue.h:

http://gerrit.cloudera.org:8080/#/c/15375/1/src/kudu/util/blocking_queue.h@277
PS1, Line 277:   size_t max_size_;
Could you declare this const?



-- 
To view, visit http://gerrit.cloudera.org:8080/15375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
Gerrit-Change-Number: 15375
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 01:08:25 +0000
Gerrit-HasComments: Yes

[kudu-CR] subprocess: add server metric for queue size

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.

Change subject: subprocess: add server metric for queue size
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/15375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d
Gerrit-Change-Number: 15375
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)