You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/03/19 02:30:00 UTC
[GitHub] [incubator-paimon] JingsongLi opened a new issue, #639: [improvement] Use new ReadBuilder and WriteBuilder API in tests
JingsongLi opened a new issue, #639:
URL: https://github.com/apache/incubator-paimon/issues/639
Stop using old interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] SteNicholas commented on issue #639: [improvement] Use new ReadBuilder and WriteBuilder API in tests
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on issue #639:
URL: https://github.com/apache/incubator-paimon/issues/639#issuecomment-1484348573
@JingsongLi, IMO, it's no need to create multiple PRs to solve this issue. @TyrantLucifer, you could create multiple commits for different modules in one PR. Please keep one commit for initial PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on issue #639: [improvement] Use new ReadBuilder and WriteBuilder API in tests
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on issue #639:
URL: https://github.com/apache/incubator-paimon/issues/639#issuecomment-1486106700
> @JingsongLi, IMO, it's no need to create multiple PRs to solve this issue. @TyrantLucifer, you could create multiple commits for different modules in one PR. Please keep one commit for initial PR.
One commit for initial PR? But create multiple commits for different modules in one PR? Can you explain more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on issue #639: [improvement] Use new ReadBuilder and WriteBuilder API in tests
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on issue #639:
URL: https://github.com/apache/incubator-paimon/issues/639#issuecomment-1475589773
> I want to try it. Could you please assign it to me?
Welcome, you can just create PR for this. I think this may need multiple PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on issue #639: [improvement] Use new ReadBuilder and WriteBuilder API in tests
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on issue #639:
URL: https://github.com/apache/incubator-paimon/issues/639#issuecomment-1486106128
Hi @TyrantLucifer , we don't just use the new ReadBuilder and WriteBuilder APIs either, we need to get rid of the FileStoreTable as well, our best practice is to use Catalog to create the Table and then follow through with the operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] TyrantLucifer commented on issue #639: [improvement] Use new ReadBuilder and WriteBuilder API in tests
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on issue #639:
URL: https://github.com/apache/incubator-paimon/issues/639#issuecomment-1475559237
I want to try it. Could you please assign it to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org