You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Andrea Cosentino (JIRA)" <ji...@apache.org> on 2019/03/20 14:14:00 UTC

[jira] [Resolved] (CAMEL-13341) camel-linkedin: If accessToken is set, other credentials should be unnecessary

     [ https://issues.apache.org/jira/browse/CAMEL-13341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrea Cosentino resolved CAMEL-13341.
--------------------------------------
    Resolution: Fixed

> camel-linkedin: If accessToken is set, other credentials should be unnecessary
> ------------------------------------------------------------------------------
>
>                 Key: CAMEL-13341
>                 URL: https://issues.apache.org/jira/browse/CAMEL-13341
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-linkedin
>    Affects Versions: 3.0.0-M1
>            Reporter: Jiri Ondrusek
>            Assignee: Andrea Cosentino
>            Priority: Major
>             Fix For: 3.0.0, 3.0.0-M2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> If you run camel-linkedin quickstart, it is possible to fill accessToken into configuration and with it, all other authentication parameters (userName, userPassword, clientId, clientSecret) are ignored, but can not be empty.
> For example this configuration works:
> {code}<bean id="linkedinConfiguration" class="org.apache.camel.component.linkedin.LinkedInConfiguration">
> 	<property name="clientId" value="null"/>
> 	<property name="clientSecret" value="null"/>
> 	<property name="redirectUri" value="https://localhost"/>
> 	<property name="userName" value="null"/>
> 	<property name="userPassword" value="null"/>
> 	<property name="accessToken" value="very long but correct access token"/>
> </bean>{code}
> But following configuration should work too (because no real value is removed from the first one):
> {code}<bean id="linkedinConfiguration" class="org.apache.camel.component.linkedin.LinkedInConfiguration">
> 	<property name="redirectUri" value="https://localhost"/>
> 	<property name="accessToken" value="very long but correct access token"/>
> </bean>{code}
> It should be possible to improve component a little bit to allow empty authentication parameters in case of filled accessToken.
> (other possible solution is to forbid accessToken functionality, but it will change back-compatibility and possibly harm some users)
> But it should not  be allowed to have filled accessToken and also authentication credential, because it will be misleading (for example accessToken could be created for different user)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)