You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/11 20:18:18 UTC
[GitHub] [arrow] domoritz opened a new pull request #9988: Remove jest-environment-node-debug and do not emit from typescript by default
domoritz opened a new pull request #9988:
URL: https://github.com/apache/arrow/pull/9988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #9988: ARROW-12333: [JS] Remove jest-environment-node-debug and do not emit from typescript by default
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#discussion_r611993143
##########
File path: js/package.json
##########
@@ -86,7 +86,6 @@
"gulp-typescript": "5.0.1",
"ix": "2.5.3",
"jest": "26.3.0",
- "jest-environment-node-debug": "2.0.0",
Review comment:
Excellent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #9988: ARROW-12333: [JS] Remove jest-environment-node-debug and do not emit from typescript by default
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #9988:
URL: https://github.com/apache/arrow/pull/9988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9988: ARROW-12333: [JS] Remove jest-environment-node-debug and do not emit from typescript by default
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#issuecomment-817367323
https://issues.apache.org/jira/browse/ARROW-12333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #9988: ARROW-12333: [JS] Remove jest-environment-node-debug and do not emit from typescript by default
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#discussion_r611241493
##########
File path: js/tsconfig.json
##########
@@ -6,6 +6,7 @@
},
"compilerOptions": {
"target": "ESNEXT",
- "module": "commonjs"
+ "module": "commonjs",
+ "noEmit": true
Review comment:
Now we can run yarn tsc to check types without accidentally writing a bunch of files.
##########
File path: js/package.json
##########
@@ -86,7 +86,6 @@
"gulp-typescript": "5.0.1",
"ix": "2.5.3",
"jest": "26.3.0",
- "jest-environment-node-debug": "2.0.0",
Review comment:
I didn't see it being used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9988: Remove jest-environment-node-debug and do not emit from typescript by default
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#issuecomment-817366444
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/.github/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #9988: ARROW-12333: [JS] Remove jest-environment-node-debug and do not emit from typescript by default
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#discussion_r611241493
##########
File path: js/tsconfig.json
##########
@@ -6,6 +6,7 @@
},
"compilerOptions": {
"target": "ESNEXT",
- "module": "commonjs"
+ "module": "commonjs",
+ "noEmit": true
Review comment:
Now we can run `yarn tsc` to check types without accidentally writing a bunch of files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] trxcllnt commented on a change in pull request #9988: ARROW-12333: [JS] Remove jest-environment-node-debug and do not emit from typescript by default
Posted by GitBox <gi...@apache.org>.
trxcllnt commented on a change in pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#discussion_r611992762
##########
File path: js/package.json
##########
@@ -86,7 +86,6 @@
"gulp-typescript": "5.0.1",
"ix": "2.5.3",
"jest": "26.3.0",
- "jest-environment-node-debug": "2.0.0",
Review comment:
yeah I think this used to be necessary for debugging, but has since been fixed in Jest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org