You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/31 14:21:24 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8975: ARROW-10990: [Rust] Refactor simd comparison kernels to avoid out of bounds reads

jorgecarleitao commented on a change in pull request #8975:
URL: https://github.com/apache/arrow/pull/8975#discussion_r550492717



##########
File path: rust/arrow/src/array/array_primitive.rs
##########
@@ -67,19 +67,6 @@ impl<T: ArrowPrimitiveType> PrimitiveArray<T> {
         self.data.is_empty()
     }
 
-    /// Returns a slice for the given offset and length

Review comment:
       I missed this one, sorry.
   
   I am fine removing it altogether. The change of signature from `safe` to `unsafe` in a previous commit already made this backward incompatible, anyways. As a user, I will prefer to migrate it to `values()[offset..offset+len]` instead of introducing an `unsafe` in my code base.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org