You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/12/02 22:02:58 UTC

[GitHub] [ignite] timoninmaxim opened a new pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

timoninmaxim opened a new pull request #8532:
URL: https://github.com/apache/ignite/pull/8532


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r558361160



##########
File path: modules/kubernetes/DEVNOTES.md
##########
@@ -34,7 +34,7 @@ Create a folder for all the files to be placed in the Docker image and copy the
     - The executable file that will start an Ignite node process from `ignite-kubernetes/config/run.sh`

Review comment:
       ```suggestion
       - The executable file that starts the Ignite node process from `ignite-kubernetes/config/run.sh`
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r558222266



##########
File path: examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.examples.client;
+
+import org.apache.ignite.Ignition;
+import org.apache.ignite.client.ClientCache;
+import org.apache.ignite.client.IgniteClient;
+import org.apache.ignite.client.ThinClientKubernetesAddressFinder;
+import org.apache.ignite.configuration.ClientConfiguration;
+import org.apache.ignite.examples.model.Address;
+import org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration;
+
+/**
+ * Demonstrates how to use Ignite thin client within the Kubernetes cluster using KubernetesConnectionConfiguration.

Review comment:
       @dmagda OK, sure




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r556610681



##########
File path: docs/_docs/thin-clients/java-thin-client.adoc
##########
@@ -86,6 +86,16 @@ The following code sample illustrates how to use the partition awareness feature
 include::{sourceCodeFile}[tag=partition-awareness,indent=0]
 ----
 
+If list of server nodes is dynamically changing or scaling than it is possible to configure connection with custom implementation of `ClientAddressFinder`. It should provide actual server addresses collection for every time client ask it.
+The following code sample illustrates how to use it.
+
+[source, java]
+----
+include::{sourceCodeFile}[tag=client-address-finder,indent=0]
+----
+
+Currently Ignite provides the only implementation of this interface. `ThinClientKubernetesAddressFinder` is created to handle scalable Kubernetes environment.

Review comment:
       ```suggestion
   Currently, Ignite provides the only implementation of this interface. `ThinClientKubernetesAddressFinder` is created to handle scalable Kubernetes environment.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r561860393



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,20 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+== Partition Awareness
+
+include::../../includes/partition-awareness.adoc[]
+
+To enable the partition awareness feature within scaling Kubernetes enviroment one should start a client within the cluster and configure it with `KubernetesConnectionConfiguration`.
+In this case, a client can connect to every pod in a cluster.
+
+Note that client configuration must be in sync with Ignite node configuration.

Review comment:
       Agree, looks confusting. Remove this sentence at all.

##########
File path: docs/_docs/thin-clients/java-thin-client.adoc
##########
@@ -86,6 +86,16 @@ The following code sample illustrates how to use the partition awareness feature
 include::{sourceCodeFile}[tag=partition-awareness,indent=0]
 ----
 
+If list of server nodes is dynamically changing or scaling than it is possible to configure connection with custom implementation of `ClientAddressFinder`. It should provide actual server addresses collection for every time client ask it.
+The following code sample illustrates how to use it.
+
+[source, java]
+----
+include::{sourceCodeFile}[tag=client-address-finder,indent=0]
+----
+
+Currently Ignite provides the only implementation of this interface. `ThinClientKubernetesAddressFinder` is created to handle scalable Kubernetes environment.

Review comment:
       @Nikita-tech-writer I've updated the docs. Could you please check it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r561974712



##########
File path: docs/_docs/thin-clients/java-thin-client.adoc
##########
@@ -86,6 +86,16 @@ The following code sample illustrates how to use the partition awareness feature
 include::{sourceCodeFile}[tag=partition-awareness,indent=0]
 ----
 
+If list of server nodes is dynamically changing or scaling than it is possible to configure connection with custom implementation of `ClientAddressFinder`. It should provide actual server addresses collection for every time client ask it.
+The following code sample illustrates how to use it.
+
+[source, java]
+----
+include::{sourceCodeFile}[tag=client-address-finder,indent=0]
+----
+
+Currently Ignite provides the only implementation of this interface. `ThinClientKubernetesAddressFinder` is created to handle scalable Kubernetes environment.

Review comment:
       @timoninmaxim Everything looks good to me! I approve the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r561868545



##########
File path: docs/_docs/thin-clients/java-thin-client.adoc
##########
@@ -86,6 +86,16 @@ The following code sample illustrates how to use the partition awareness feature
 include::{sourceCodeFile}[tag=partition-awareness,indent=0]
 ----
 
+If list of server nodes is dynamically changing or scaling than it is possible to configure connection with custom implementation of `ClientAddressFinder`. It should provide actual server addresses collection for every time client ask it.
+The following code sample illustrates how to use it.
+
+[source, java]
+----
+include::{sourceCodeFile}[tag=client-address-finder,indent=0]
+----
+
+Currently Ignite provides the only implementation of this interface. `ThinClientKubernetesAddressFinder` is created to handle scalable Kubernetes environment.

Review comment:
       @Nikita-tech-writer I've updated the docs. Could you please check it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r558348736



##########
File path: docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/JavaThinClient.java
##########
@@ -360,6 +360,26 @@ void partitionAwareness() throws Exception {
         //end::partition-awareness[]
     }
 
+    void clientAddressFinder() throws Exception {
+        //tag::client-address-finder[]
+        ClientAddressFinder finder = () -> {
+            String[] dynamicServerAddresses = fetchServerAddresses();
+
+            return dynamicServerAddresses;
+        };
+
+        ClientConfiguration cfg = new ClientConfiguration()
+            .setAddressFinder(finder)
+            .setPartitionAwarenessEnabled(true);
+
+        try (IgniteClient client = Ignition.startClient(cfg)) {
+            ClientCache<Integer, String> cache = client.cache("myCache");
+            // Put, get or remove data from the cache...

Review comment:
       ```suggestion
               // Put, get, or remove data from the cache...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r556608893



##########
File path: docs/_docs/thin-clients/java-thin-client.adoc
##########
@@ -86,6 +86,16 @@ The following code sample illustrates how to use the partition awareness feature
 include::{sourceCodeFile}[tag=partition-awareness,indent=0]
 ----
 
+If list of server nodes is dynamically changing or scaling than it is possible to configure connection with custom implementation of `ClientAddressFinder`. It should provide actual server addresses collection for every time client ask it.

Review comment:
       ```suggestion
   If a list of server nodes is dynamically changing or scaling, then it is possible to configure the connection with custom implementation of `ClientAddressFinder`. It should provide a number of current server addresses every time a client asks for them.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r558362444



##########
File path: modules/kubernetes/config/Dockerfile
##########
@@ -18,14 +18,17 @@
 # Use Java 8 image as default one.
 FROM openjdk:8
 
+# Set Apache Ignite configuration file name.
+ARG IGNITE_CFG_XML="example-kube.xml"
+
 # Set Apache Ignite version.
-ENV IGNITE_VERSION 2.0.0-SNAPSHOT
+ARG IGNITE_VERSION="2.0.0"
 
 # Set IGNITE_HOME variable.
 ENV IGNITE_HOME /opt/ignite/apache-ignite-${IGNITE_VERSION}-bin
 
 # Setting a path to an Apache Ignite configuration file. Used by run.sh script below.
-ENV CONFIG_URI ${IGNITE_HOME}/config/example-kube.xml
+ENV CONFIG_URI ${IGNITE_HOME}/config/$IGNITE_CFG_XML
 
 # Make sure kubernetes lib is copied to 'libs' folder.

Review comment:
       ```suggestion
   # Make sure the Kubernetes lib is copied to the 'libs' folder.
   ```

##########
File path: modules/kubernetes/config/Dockerfile
##########
@@ -51,7 +54,7 @@ COPY ./run.sh $IGNITE_HOME/
 RUN chmod +x $IGNITE_HOME/run.sh
 
 # Copying the configuration.

Review comment:
       ```suggestion
   # Copy the configuration.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf merged pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Mmuzaf merged pull request #8532:
URL: https://github.com/apache/ignite/pull/8532


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r555238433



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,17 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+Thin clients support the partition awareness feature that may speed up operations. Thin clients store a mapping of Ignite nodes to cache partitions and send partition requests directly to the right node.
+A client connected to the Kubernetes cluster through Ingress can't build such a map. Instead, to activate the feature, one should start a client within the cluster and configure it with KubernetesConnectionConfiguration.

Review comment:
       Hi @timoninmaxim , I'll give you the feedback shortly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r558362737



##########
File path: modules/kubernetes/config/Dockerfile
##########
@@ -51,7 +54,7 @@ COPY ./run.sh $IGNITE_HOME/
 RUN chmod +x $IGNITE_HOME/run.sh
 
 # Copying the configuration.
-COPY ./example-kube.xml $IGNITE_HOME/config
+COPY ./$IGNITE_CFG_XML $IGNITE_HOME/config
 
 # Starting an Apache Ignite node.

Review comment:
       ```suggestion
   # Start an Apache Ignite node.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r558362116



##########
File path: modules/kubernetes/config/Dockerfile
##########
@@ -18,14 +18,17 @@
 # Use Java 8 image as default one.
 FROM openjdk:8
 
+# Set Apache Ignite configuration file name.
+ARG IGNITE_CFG_XML="example-kube.xml"
+
 # Set Apache Ignite version.
-ENV IGNITE_VERSION 2.0.0-SNAPSHOT
+ARG IGNITE_VERSION="2.0.0"
 
 # Set IGNITE_HOME variable.
 ENV IGNITE_HOME /opt/ignite/apache-ignite-${IGNITE_VERSION}-bin
 
 # Setting a path to an Apache Ignite configuration file. Used by run.sh script below.

Review comment:
       ```suggestion
   # Set a path to the Apache Ignite configuration file. Use the run.sh script below:
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r548903598



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,17 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+Thin clients support the partition awareness feature that may speed up operations. Thin clients store a mapping of Ignite nodes to cache partitions and send partition requests directly to the right node.
+A client connected to the Kubernetes cluster through Ingress can't build such a map. Instead, to activate the feature, one should start a client within the cluster and configure it with KubernetesConnectionConfiguration.

Review comment:
       Hi @timoninmaxim,
   Yes, I will start to work on this ticket after the NY holidays, so you can add it to docs for sure. Thank you.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r559459712



##########
File path: docs/_docs/thin-clients/java-thin-client.adoc
##########
@@ -86,6 +86,16 @@ The following code sample illustrates how to use the partition awareness feature
 include::{sourceCodeFile}[tag=partition-awareness,indent=0]
 ----
 
+If list of server nodes is dynamically changing or scaling than it is possible to configure connection with custom implementation of `ClientAddressFinder`. It should provide actual server addresses collection for every time client ask it.
+The following code sample illustrates how to use it.
+
+[source, java]
+----
+include::{sourceCodeFile}[tag=client-address-finder,indent=0]
+----
+
+Currently Ignite provides the only implementation of this interface. `ThinClientKubernetesAddressFinder` is created to handle scalable Kubernetes environment.

Review comment:
       @dmagda @Nikita-tech-writer  
   To mention this only implementation is may be important to provide an existing example of the interface implementation.
   
   Yes, your understanding is correct.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r556604555



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,20 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+== Partition Awareness
+
+include::../../includes/partition-awareness.adoc[]
+
+To enable the partition awareness feature within scaling Kubernetes enviroment one should start a client within the cluster and configure it with `KubernetesConnectionConfiguration`.
+In this case, a client can connect to every pod in a cluster.
+
+Note that client configuration must be in sync with Ignite node configuration.

Review comment:
       ```suggestion
   Note that client configuration must be in sync with the Ignite node configuration.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r561860393



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,20 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+== Partition Awareness
+
+include::../../includes/partition-awareness.adoc[]
+
+To enable the partition awareness feature within scaling Kubernetes enviroment one should start a client within the cluster and configure it with `KubernetesConnectionConfiguration`.
+In this case, a client can connect to every pod in a cluster.
+
+Note that client configuration must be in sync with Ignite node configuration.

Review comment:
       Agree, looks confusting. Remove this sentence at all.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r556603959



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,20 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+== Partition Awareness
+
+include::../../includes/partition-awareness.adoc[]
+
+To enable the partition awareness feature within scaling Kubernetes enviroment one should start a client within the cluster and configure it with `KubernetesConnectionConfiguration`.

Review comment:
       ```suggestion
   To enable the partition awareness feature within scaling Kubernetes enviroment, one should start a client within the cluster and configure it with `KubernetesConnectionConfiguration`.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] dmagda commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
dmagda commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r535561492



##########
File path: docs/_docs/code-snippets/k8s/stateful/node-configuration.xml
##########
@@ -16,11 +16,17 @@
   limitations under the License.
 -->
 <beans xmlns="http://www.springframework.org/schema/beans"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
-    xsi:schemaLocation="http://www.springframework.org/schema/beans         
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://www.springframework.org/schema/beans
     http://www.springframework.org/schema/beans/spring-beans.xsd">
 
     <!-- tag::config-block[] -->
+    <bean class="org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration" name="k8sCfg">

Review comment:
       I would put this bean definition into the TcpDiscoveryKubernetesIpFinder bean right away. Simplifies readability. Plus, the KubernetesConnectionConfiguration bean is used only by the TcpDiscoveryKubernetesIpFinder bean; thus it should be fine to put one inside of another right away.
   
   Please consider such a change for similar places below.
   
   

##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,17 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+Thin clients support the partition awareness feature that may speed up operations. Thin clients store a mapping of Ignite nodes to cache partitions and send partition requests directly to the right node.
+A client connected to the Kubernetes cluster through Ingress can't build such a map. Instead, to activate the feature, one should start a client within the cluster and configure it with KubernetesConnectionConfiguration.

Review comment:
       A not for Nikita Safonov, who will be reviewing and editing the doc. 
   
   I would probably put these details on the thin client documentation page. And add a callout to this Kubernetes pages saying that you need to enable a thin-client specific IP finder (providing a reference to the thin client page for mode details).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r554925845



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,17 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+Thin clients support the partition awareness feature that may speed up operations. Thin clients store a mapping of Ignite nodes to cache partitions and send partition requests directly to the right node.
+A client connected to the Kubernetes cluster through Ingress can't build such a map. Instead, to activate the feature, one should start a client within the cluster and configure it with KubernetesConnectionConfiguration.

Review comment:
       @Nikita-tech-writer hi! I've updated docs and push. Please let me know if it is ok or not.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#issuecomment-762150549


   @Nikita-tech-writer I've commited most of you suggestions, thanks! I wrote a comment for the only non-commited suggestion.
   
   Also I'm going to fix the comment @dmagda about docs with the `fetchServerAddresses` method. I will prepare a patch for it today, than ask @Nikita-tech-writer to review it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#issuecomment-760204058


   @dmagda Could you please also take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r548883952



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,17 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+Thin clients support the partition awareness feature that may speed up operations. Thin clients store a mapping of Ignite nodes to cache partitions and send partition requests directly to the right node.
+A client connected to the Kubernetes cluster through Ingress can't build such a map. Instead, to activate the feature, one should start a client within the cluster and configure it with KubernetesConnectionConfiguration.

Review comment:
       Hi, I'm agree that there should be part of ClientAddressFinder in thin client. As any user can write own implementation of this interface and use it within any (not only k8s env).
   
   @dmagda @Nikita-tech-writer Nikita, if you didn't start work on this ticket yet I will add this to docs. Please let me know you current status on this ticket




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r548883140



##########
File path: docs/_docs/code-snippets/k8s/stateful/node-configuration.xml
##########
@@ -16,11 +16,17 @@
   limitations under the License.
 -->
 <beans xmlns="http://www.springframework.org/schema/beans"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
-    xsi:schemaLocation="http://www.springframework.org/schema/beans         
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://www.springframework.org/schema/beans
     http://www.springframework.org/schema/beans/spring-beans.xsd">
 
     <!-- tag::config-block[] -->
+    <bean class="org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration" name="k8sCfg">

Review comment:
       fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r558359674



##########
File path: examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.examples.client;
+
+import org.apache.ignite.Ignition;
+import org.apache.ignite.client.ClientCache;
+import org.apache.ignite.client.IgniteClient;
+import org.apache.ignite.client.ThinClientKubernetesAddressFinder;
+import org.apache.ignite.configuration.ClientConfiguration;
+import org.apache.ignite.examples.model.Address;
+import org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration;
+
+/**
+ * Demonstrates how to use Ignite thin client within the Kubernetes cluster using KubernetesConnectionConfiguration.
+ * <p>
+ * Prerequisites:
+ * <ul>
+ * <li>Running Ignite Kubernetes cluster. Check modules/kubernetes/DEVNOTES.md for example how to run a cluster locally.</li>

Review comment:
       ```suggestion
    * <li>Running Ignite Kubernetes cluster. Check modules/kubernetes/DEVNOTES.md as an example of how to run a cluster locally.</li>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r561974712



##########
File path: docs/_docs/thin-clients/java-thin-client.adoc
##########
@@ -86,6 +86,16 @@ The following code sample illustrates how to use the partition awareness feature
 include::{sourceCodeFile}[tag=partition-awareness,indent=0]
 ----
 
+If list of server nodes is dynamically changing or scaling than it is possible to configure connection with custom implementation of `ClientAddressFinder`. It should provide actual server addresses collection for every time client ask it.
+The following code sample illustrates how to use it.
+
+[source, java]
+----
+include::{sourceCodeFile}[tag=client-address-finder,indent=0]
+----
+
+Currently Ignite provides the only implementation of this interface. `ThinClientKubernetesAddressFinder` is created to handle scalable Kubernetes environment.

Review comment:
       @timoninmaxim Everything looks good to me! I approve the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf merged pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Mmuzaf merged pull request #8532:
URL: https://github.com/apache/ignite/pull/8532


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r559456089



##########
File path: examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.examples.client;
+
+import org.apache.ignite.Ignition;
+import org.apache.ignite.client.ClientCache;
+import org.apache.ignite.client.IgniteClient;
+import org.apache.ignite.client.ThinClientKubernetesAddressFinder;
+import org.apache.ignite.configuration.ClientConfiguration;
+import org.apache.ignite.examples.model.Address;
+import org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration;
+
+/**
+ * Demonstrates how to use Ignite thin client within the Kubernetes cluster using KubernetesConnectionConfiguration.
+ * <p>
+ * Prerequisites:
+ * <ul>
+ * <li>Running Ignite Kubernetes cluster. Check modules/kubernetes/DEVNOTES.md for example how to run a cluster locally.</li>
+ * <li>A thin client application should be run within the cluster to have access to Ignite nodes pods.</li>

Review comment:
       Thin client does not "provide" access to Ignite, but do "have" the access to it within the cluster. I mean that there is no access to cluster if thin client isn't running within the cluster. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] dmagda commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
dmagda commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r557781530



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,20 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+== Partition Awareness
+
+include::../../includes/partition-awareness.adoc[]
+
+To enable the partition awareness feature within scaling Kubernetes enviroment one should start a client within the cluster and configure it with `KubernetesConnectionConfiguration`.
+In this case, a client can connect to every pod in a cluster.
+
+Note that client configuration must be in sync with Ignite node configuration.

Review comment:
       What does this sentence mean? What type of synchronization is assumed? Confusing.

##########
File path: examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.examples.client;
+
+import org.apache.ignite.Ignition;
+import org.apache.ignite.client.ClientCache;
+import org.apache.ignite.client.IgniteClient;
+import org.apache.ignite.client.ThinClientKubernetesAddressFinder;
+import org.apache.ignite.configuration.ClientConfiguration;
+import org.apache.ignite.examples.model.Address;
+import org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration;
+
+/**
+ * Demonstrates how to use Ignite thin client within the Kubernetes cluster using KubernetesConnectionConfiguration.

Review comment:
       @Nikita-tech-writer, please check the comments in the source code files too. I see some spellings below.

##########
File path: docs/_docs/thin-clients/java-thin-client.adoc
##########
@@ -86,6 +86,16 @@ The following code sample illustrates how to use the partition awareness feature
 include::{sourceCodeFile}[tag=partition-awareness,indent=0]
 ----
 
+If list of server nodes is dynamically changing or scaling than it is possible to configure connection with custom implementation of `ClientAddressFinder`. It should provide actual server addresses collection for every time client ask it.
+The following code sample illustrates how to use it.
+
+[source, java]
+----
+include::{sourceCodeFile}[tag=client-address-finder,indent=0]
+----
+
+Currently Ignite provides the only implementation of this interface. `ThinClientKubernetesAddressFinder` is created to handle scalable Kubernetes environment.

Review comment:
       I don't understand what the sentence means. You say "Ignite provides the only implementation of this interface". What interface is assumed? Why is it important to mention this only implementation?
   
   Instead, provide a bullet-point list explaining the code snippet. The snippet has the `fetchServerAddresses` method that is not implemented. It seems that you are trying to say that "The fetchServerAddress() method shows how an example implementation might look like if you want clients to retrieve the server nodes' addresses dynamically. If you are running in a Kubernetes environment then use the `ThinClientKubernetesAddressFinder` in your thin client configuration to enable the automatic resolution of the server addresses on the client side".  Nikita please help to adjust the latter if Maxim confirms that my understanding is correct.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r558360750



##########
File path: modules/kubernetes/DEVNOTES.md
##########
@@ -34,7 +34,7 @@ Create a folder for all the files to be placed in the Docker image and copy the
     - The executable file that will start an Ignite node process from `ignite-kubernetes/config/run.sh`
 
 Go to the folder and execute a command below to prepare the image:

Review comment:
       ```suggestion
   To prepare the image, navigate to the folder and execute the following command:
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r558359275



##########
File path: examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.examples.client;
+
+import org.apache.ignite.Ignition;
+import org.apache.ignite.client.ClientCache;
+import org.apache.ignite.client.IgniteClient;
+import org.apache.ignite.client.ThinClientKubernetesAddressFinder;
+import org.apache.ignite.configuration.ClientConfiguration;
+import org.apache.ignite.examples.model.Address;
+import org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration;
+
+/**
+ * Demonstrates how to use Ignite thin client within the Kubernetes cluster using KubernetesConnectionConfiguration.
+ * <p>
+ * Prerequisites:
+ * <ul>
+ * <li>Running Ignite Kubernetes cluster. Check modules/kubernetes/DEVNOTES.md for example how to run a cluster locally.</li>
+ * <li>A thin client application should be run within the cluster to have access to Ignite nodes pods.</li>

Review comment:
       ```suggestion
    * <li>A thin client application should be run within the cluster to provide access to the Ignite nodes pods.</li>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r559695567



##########
File path: examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.examples.client;
+
+import org.apache.ignite.Ignition;
+import org.apache.ignite.client.ClientCache;
+import org.apache.ignite.client.IgniteClient;
+import org.apache.ignite.client.ThinClientKubernetesAddressFinder;
+import org.apache.ignite.configuration.ClientConfiguration;
+import org.apache.ignite.examples.model.Address;
+import org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration;
+
+/**
+ * Demonstrates how to use Ignite thin client within the Kubernetes cluster using KubernetesConnectionConfiguration.
+ * <p>
+ * Prerequisites:
+ * <ul>
+ * <li>Running Ignite Kubernetes cluster. Check modules/kubernetes/DEVNOTES.md for example how to run a cluster locally.</li>
+ * <li>A thin client application should be run within the cluster to have access to Ignite nodes pods.</li>

Review comment:
       OK, got it, thanks for the explanation!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timoninmaxim commented on a change in pull request #8532: IGNITE-13796 docs: update docs and examples for kubernetes module

Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r559460140



##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,20 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service.
 include::{javaFile}[tags=connectThinClient, indent=0]
 ----
 
+== Partition Awareness
+
+include::../../includes/partition-awareness.adoc[]
+
+To enable the partition awareness feature within scaling Kubernetes enviroment one should start a client within the cluster and configure it with `KubernetesConnectionConfiguration`.
+In this case, a client can connect to every pod in a cluster.
+
+Note that client configuration must be in sync with Ignite node configuration.

Review comment:
       I mean that list of addresses in ClientConfiguration must be in sync with list of addresses of IgniteConfiguration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org