You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/27 14:15:53 UTC
[GitHub] [arrow] cyb70289 opened a new pull request, #13253: MINOR: [C++] Fix foreach usage in Usevcpkg.cmake
cyb70289 opened a new pull request, #13253:
URL: https://github.com/apache/arrow/pull/13253
`foreach(out IN LISTS list1 list2 "item")` will not iterate "item".
Should be `foreach(out IN LISTS list1 list2 IN ITEMS "item")`,
or simpler `foreach(out ${list1} ${list2} "item")`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a diff in pull request #13253: MINOR: [C++] Fix foreach usage in Usevcpkg.cmake
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on code in PR #13253:
URL: https://github.com/apache/arrow/pull/13253#discussion_r883659349
##########
cpp/cmake_modules/Usevcpkg.cmake:
##########
@@ -121,7 +121,7 @@ set(_INST_BUILD_DIR "${CMAKE_CURRENT_BINARY_DIR}/vcpkg_installed") # try here fi
set(_INST_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/vcpkg_installed") # try here second
set(_INST_VCPKG_ROOT "${VCPKG_ROOT}/installed")
# Iterate over the places
-foreach(_INST_DIR IN LISTS _INST_BUILD_DIR _INST_SOURCE_DIR _INST_VCPKG_ROOT "notfound")
Review Comment:
This does not iterate "notfound".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #13253: MINOR: [C++] Fix foreach usage in Usevcpkg.cmake
Posted by GitBox <gi...@apache.org>.
kou merged PR #13253:
URL: https://github.com/apache/arrow/pull/13253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org