You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/07/04 01:07:48 UTC

[6/6] impala git commit: IMPALA-7236: Fix the parsing of ALLOW_ERASURE_CODED_FILES

IMPALA-7236: Fix the parsing of ALLOW_ERASURE_CODED_FILES

This patch adds a missing "break" statement in a switch statement
changed by IMPALA-7102.
Also fixes an non-deterministic test case.

Change-Id: Ife1e791541e3f4fed6bec00945390c7d7681e824
Reviewed-on: http://gerrit.cloudera.org:8080/10857
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/61e6a477
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/61e6a477
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/61e6a477

Branch: refs/heads/master
Commit: 61e6a47776ba7f14139b69f91a49d2072a76178b
Parents: 4ff9f5f
Author: Tianyi Wang <ti...@apache.org>
Authored: Mon Jul 2 19:03:19 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Tue Jul 3 23:49:44 2018 +0000

----------------------------------------------------------------------
 be/src/service/query-options.cc                                    | 1 +
 .../functional-query/queries/QueryTest/hdfs-erasure-coding.test    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/61e6a477/be/src/service/query-options.cc
----------------------------------------------------------------------
diff --git a/be/src/service/query-options.cc b/be/src/service/query-options.cc
index 1063fef..5d61664 100644
--- a/be/src/service/query-options.cc
+++ b/be/src/service/query-options.cc
@@ -674,6 +674,7 @@ Status impala::SetQueryOption(const string& key, const string& value,
           return Status(Substitute("Invalid kudu_read_mode '$0'. Valid values are "
               "DEFAULT, READ_LATEST, and READ_AT_SNAPSHOT.", value));
         }
+        break;
       }
       case TImpalaQueryOptions::ALLOW_ERASURE_CODED_FILES: {
         query_options->__set_allow_erasure_coded_files(

http://git-wip-us.apache.org/repos/asf/impala/blob/61e6a477/testdata/workloads/functional-query/queries/QueryTest/hdfs-erasure-coding.test
----------------------------------------------------------------------
diff --git a/testdata/workloads/functional-query/queries/QueryTest/hdfs-erasure-coding.test b/testdata/workloads/functional-query/queries/QueryTest/hdfs-erasure-coding.test
index 0c773b4..fbe05c6 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/hdfs-erasure-coding.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/hdfs-erasure-coding.test
@@ -3,7 +3,7 @@
 set allow_erasure_coded_files=false;
 select count(*) from functional.alltypes;
 ---- CATCH
-ImpalaRuntimeException: Scanning of HDFS erasure-coded file (hdfs://localhost:20500/test-warehouse/alltypes/year=2009/month=1/090101.txt) is not supported
+ImpalaRuntimeException: Scanning of HDFS erasure-coded file
 ====
 ---- QUERY
 set allow_erasure_coded_files=true;