You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "asl3 (via GitHub)" <gi...@apache.org> on 2024/01/29 22:57:50 UTC
[PR] [SPARK-46910][PYTHON] Eliminate JDK Requirement in PySpark Installation [spark]
asl3 opened a new pull request, #44940:
URL: https://github.com/apache/spark/pull/44940
### What changes were proposed in this pull request?
Modifies the PySpark installation script to ask users to allow installation of the necessary JDK, if not already installed.
### Why are the changes needed?
Simplifying the PySpark installation process is a critical part of improving the new user onboarding experience. Many new PySpark users get blocked in the installation process, due to confusing errors from not having Java installed. This change simplifies the PySpark user onboarding process.
### Does this PR introduce _any_ user-facing change?
Yes, modifies the PySpark installation script.
### How was this patch tested?
Installing PySpark in virtual environments
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46910][PYTHON] Eliminate JDK Requirement in PySpark Installation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44940:
URL: https://github.com/apache/spark/pull/44940#discussion_r1470428682
##########
bin/pyspark:
##########
@@ -48,6 +48,35 @@ export PYSPARK_PYTHON
export PYSPARK_DRIVER_PYTHON
export PYSPARK_DRIVER_PYTHON_OPTS
+# Attempt to find JAVA_HOME.
+# If JAVA_HOME not set, install JDK 17 and set JAVA_HOME using a temp dir, and adding the
+# temp dir to the PYTHONPATH.
+if [ -n "${JAVA_HOME}" ]; then
+ RUNNER="${JAVA_HOME}/bin/java"
+else
+ if [ "$(command -v java)" ]; then
+ RUNNER="java"
+ else
+ echo -n "JAVA_HOME is not set. Would you like to install JDK 17 and set JAVA_HOME? (Y/N) " >&2
+
+ read -r input
+
+ if [[ "${input,,}" == "y" ]]; then
+ TEMP_DIR=$(mktemp -d)
+ $PYSPARK_DRIVER_PYTHON -m pip install --target="$TEMP_DIR" install-jdk
+ export JAVA_HOME=$(PYTHONPATH="$TEMP_DIR" $PYSPARK_DRIVER_PYTHON -c 'import jdk; print(jdk.install("17"))')
+ RUNNER="${JAVA_HOME}/bin/java"
+ echo "JDK was installed to the path \"$JAVA_HOME\""
+ echo "You can avoid needing to re-install JDK by setting your JAVA_HOME environment variable"\
+ "to \"$JAVA_HOME\""
Review Comment:
```suggestion
echo "You can avoid needing to re-install JDK by setting your JAVA_HOME environment variable to \"$JAVA_HOME\""
```
##########
bin/pyspark:
##########
@@ -48,6 +48,35 @@ export PYSPARK_PYTHON
export PYSPARK_DRIVER_PYTHON
export PYSPARK_DRIVER_PYTHON_OPTS
+# Attempt to find JAVA_HOME.
+# If JAVA_HOME not set, install JDK 17 and set JAVA_HOME using a temp dir, and adding the
+# temp dir to the PYTHONPATH.
+if [ -n "${JAVA_HOME}" ]; then
+ RUNNER="${JAVA_HOME}/bin/java"
+else
+ if [ "$(command -v java)" ]; then
+ RUNNER="java"
+ else
+ echo -n "JAVA_HOME is not set. Would you like to install JDK 17 and set JAVA_HOME? (Y/N) " >&2
+
+ read -r input
+
+ if [[ "${input,,}" == "y" ]]; then
+ TEMP_DIR=$(mktemp -d)
+ $PYSPARK_DRIVER_PYTHON -m pip install --target="$TEMP_DIR" install-jdk
+ export JAVA_HOME=$(PYTHONPATH="$TEMP_DIR" $PYSPARK_DRIVER_PYTHON -c 'import jdk; print(jdk.install("17"))')
+ RUNNER="${JAVA_HOME}/bin/java"
+ echo "JDK was installed to the path \"$JAVA_HOME\""
+ echo "You can avoid needing to re-install JDK by setting your JAVA_HOME environment variable"\
+ "to \"$JAVA_HOME\""
+ else
+ echo "JDK installation skipped."\
+ "You can manually install JDK (17 or later) and set JAVA_HOME in your environment."
Review Comment:
```suggestion
echo "JDK installation skipped. You can manually install JDK (17 or later) and set JAVA_HOME in your environment."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46910][PYTHON] Eliminate JDK Requirement in PySpark Installation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44940: [SPARK-46910][PYTHON] Eliminate JDK Requirement in PySpark Installation
URL: https://github.com/apache/spark/pull/44940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46910][PYTHON] Eliminate JDK Requirement in PySpark Installation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44940:
URL: https://github.com/apache/spark/pull/44940#issuecomment-1915847236
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46910][PYTHON] Eliminate JDK Requirement in PySpark Installation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44940:
URL: https://github.com/apache/spark/pull/44940#discussion_r1470428827
##########
bin/pyspark:
##########
@@ -48,6 +48,35 @@ export PYSPARK_PYTHON
export PYSPARK_DRIVER_PYTHON
export PYSPARK_DRIVER_PYTHON_OPTS
+# Attempt to find JAVA_HOME.
+# If JAVA_HOME not set, install JDK 17 and set JAVA_HOME using a temp dir, and adding the
+# temp dir to the PYTHONPATH.
+if [ -n "${JAVA_HOME}" ]; then
+ RUNNER="${JAVA_HOME}/bin/java"
+else
+ if [ "$(command -v java)" ]; then
+ RUNNER="java"
+ else
+ echo -n "JAVA_HOME is not set. Would you like to install JDK 17 and set JAVA_HOME? (Y/N) " >&2
+
+ read -r input
+
+ if [[ "${input,,}" == "y" ]]; then
+ TEMP_DIR=$(mktemp -d)
+ $PYSPARK_DRIVER_PYTHON -m pip install --target="$TEMP_DIR" install-jdk
+ export JAVA_HOME=$(PYTHONPATH="$TEMP_DIR" $PYSPARK_DRIVER_PYTHON -c 'import jdk; print(jdk.install("17"))')
+ RUNNER="${JAVA_HOME}/bin/java"
+ echo "JDK was installed to the path \"$JAVA_HOME\""
+ echo "You can avoid needing to re-install JDK by setting your JAVA_HOME environment variable"\
+ "to \"$JAVA_HOME\""
+ else
+ echo "JDK installation skipped."\
+ "You can manually install JDK (17 or later) and set JAVA_HOME in your environment."
Review Comment:
```suggestion
echo "JDK installation skipped. You can manually install JDK (17 or later) and set JAVA_HOME in your environment."
```
##########
bin/pyspark:
##########
@@ -48,6 +48,35 @@ export PYSPARK_PYTHON
export PYSPARK_DRIVER_PYTHON
export PYSPARK_DRIVER_PYTHON_OPTS
+# Attempt to find JAVA_HOME.
+# If JAVA_HOME not set, install JDK 17 and set JAVA_HOME using a temp dir, and adding the
+# temp dir to the PYTHONPATH.
+if [ -n "${JAVA_HOME}" ]; then
+ RUNNER="${JAVA_HOME}/bin/java"
+else
+ if [ "$(command -v java)" ]; then
+ RUNNER="java"
+ else
+ echo -n "JAVA_HOME is not set. Would you like to install JDK 17 and set JAVA_HOME? (Y/N) " >&2
+
+ read -r input
+
+ if [[ "${input,,}" == "y" ]]; then
+ TEMP_DIR=$(mktemp -d)
+ $PYSPARK_DRIVER_PYTHON -m pip install --target="$TEMP_DIR" install-jdk
+ export JAVA_HOME=$(PYTHONPATH="$TEMP_DIR" $PYSPARK_DRIVER_PYTHON -c 'import jdk; print(jdk.install("17"))')
+ RUNNER="${JAVA_HOME}/bin/java"
+ echo "JDK was installed to the path \"$JAVA_HOME\""
+ echo "You can avoid needing to re-install JDK by setting your JAVA_HOME environment variable"\
+ "to \"$JAVA_HOME\""
Review Comment:
```suggestion
echo "You can avoid needing to re-install JDK by setting your JAVA_HOME environment variable to \"$JAVA_HOME\""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org