[jira] [Commented] (CLOUDSTACK-10068) smoketest/test_iso.py reports assertion failure

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166169#comment-16166169 ] 

ASF subversion and git services commented on CLOUDSTACK-10068:
--------------------------------------------------------------

Commit d84585fa6ea23a33392a85b3fa7532308c722d1e in cloudstack's branch refs/heads/master from [~bstoyanov]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=d84585f ]

CLOUDSTACK-10068: Fixing test_iso.py assertions are equating srt and bool instead of the same types (#2261)

It appears that asserts.equal(boolean.True, str.True) which seems to be causing the issue. Probably related to some api changes in recent PRs. Will fix the equation to str.lower() so it'll pass.

Strangely when running the tests from Pycharm CE they pass, it seems the IDE resolves the type issue during comparison. But when running from command line it failes...

After fixing this results came back as expected:

> smoketest/test_iso.py reports assertion failure
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-10068
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10068
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: marvin
>            Reporter: Boris Stoyanov
>
> The following was reported from recent smoketest runs
> {code}2017-09-04 11:23:16,432 - CRITICAL - FAILED: test_02_edit_iso: ['Traceback (most recent call last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n    testMethod()\n', '  File "/marvin/tests/smoke/test_iso.py", line 327, in test_02_edit_iso\n    "Check if image is bootable of updated ISO"\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual\n    assertion_func(first, second, msg=msg)\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual\n    raise self.failureException(msg)\n', 'AssertionError: Check if image is bootable of updated ISO\n']
> 2017-09-04 11:24:56,797 - CRITICAL - FAILED: test_05_iso_permissions: ['Traceback (most recent call last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n    testMethod()\n', '  File "/marvin/tests/smoke/test_iso.py", line 480, in test_05_iso_permissions\n    "Check ispublic permission of ISO"\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual\n    assertion_func(first, second, msg=msg)\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual\n    raise self.failureException(msg)\n', 'AssertionError: Check ispublic permission of ISO\n']
> {code}
> It appears that asserts.equal(boolean.True, str.True) which seems to be causing the issue. Probably related to some api changes in recent PRs. Will fix the equation to str.lower() so it'll pass. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)