[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #115: Assign partition again if registerShuffleServers failed

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #115:
URL: https://github.com/apache/incubator-uniffle/pull/115#discussion_r934502470


##########
client-mr/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -221,13 +189,64 @@ public Thread newThread(Runnable r) {
         conf.setInt(MRJobConfig.REDUCE_MAX_ATTEMPTS, originalAttempts + inc);
       }
 
-      LOG.info("Start to register shuffle");
-      long start = System.currentTimeMillis();
-      serverToPartitionRanges.entrySet().forEach(entry -> {
-        client.registerShuffle(
-            entry.getKey(), appId, 0, entry.getValue(), remoteStorage);
+      // retryInterval must bigger than `rss.server.heartbeat.timeout`, or maybe it will return the same result

Review Comment:
   Could the `retryInterval` be configuration option? And check this configuration option like
   ```
   if (retryInterval < heartbeatTimeout) {
      LOG.warn("xxx");
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org