[jira] [Commented] (GEODE-3411) Do Final check based on suspected member-timeout.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297501#comment-16297501 ] 

ASF GitHub Bot commented on GEODE-3411:
---------------------------------------

bschuchardt commented on a change in pull request #1075: GEODE-3411 Do Final check based on suspected member-timeout
URL: https://github.com/apache/geode/pull/1075#discussion_r157884625
 
 

 ##########
 File path: geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetView.java
 ##########
 @@ -597,6 +610,9 @@ public void toData(DataOutput out) throws IOException {
     DataSerializer.writeIntArray(failureDetectionPorts, out);
     // TODO expensive serialization
     DataSerializer.writeHashMap(publicKeys, out);
+    if (InternalDataSerializer.getVersionForDataStream(out).compareTo(Version.GEODE_120) >= 0) {
 
 Review comment:
   geode 1.3.0 has been released so this and other places need to be changed to GEODE_140

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Do Final check based on suspected member-timeout.
> -------------------------------------------------
>
>                 Key: GEODE-3411
>                 URL: https://issues.apache.org/jira/browse/GEODE-3411
>             Project: Geode
>          Issue Type: Wish
>          Components: membership
>            Reporter: Aravind M
>
> The idea is able to make critical member to survive in the view for a little longer time than others.
> But we cannot do with the current suspect mechanism.
> Now a member can be removed from the view in two cases: one is missing heartbeat and second is missing acknowledgement of message.
> In the first case ,the final check is done by coordinators member-timeout and in the second case the final check done by suspecting member by its own timeout.
> So, in these two cases if we manage to suspect the member by the member-timeout of the suspected one in the final check then we can achieve to make a member survive in the view a little longer by configuring a greater member-timeout to that member.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)