You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/03/07 10:36:05 UTC

Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18016/
-----------------------------------------------------------

(Updated March 7, 2014, 3:06 p.m.)


Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.


Changes
-------

Rebased and tested with latest master. Talluri, can you please commit this?


Bugs: CLOUDSTACK-5626
    https://issues.apache.org/jira/browse/CLOUDSTACK-5626


Repository: cloudstack-git


Description
-------

Removing different ways of obtaining suitable hosts. Used built in API "findHostsForMigration" and skipped the test if suitable host is not found instead of throwing assertion error.
Removed unnecessary common function.


Diffs (updated)
-----

  test/integration/component/test_cpu_domain_limits.py c427e4f 
  test/integration/component/test_cpu_limits.py bdf2869 
  test/integration/component/test_cpu_project_limits.py a8a1b3c 
  test/integration/component/test_memory_limits.py 7921e4b 
  test/integration/component/test_mm_domain_limits.py 68660c1 
  test/integration/component/test_mm_project_limits.py c314011 
  test/integration/component/test_vpc_vm_life_cycle.py 01373ac 
  tools/marvin/marvin/codes.py 3882f0d 
  tools/marvin/marvin/integration/lib/common.py b2da3ff 

Diff: https://reviews.apache.org/r/18016/diff/


Testing
-------

Yes.


Thanks,

Gaurav Aradhye

Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18016/#review36628
-----------------------------------------------------------


Commit 3b3ae024591fae4db9a6ca991d4838d98b96154e in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3b3ae02 ]

CLOUDSTACK-5626: Simplifying VM Migrate code

Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>


- ASF Subversion and Git Services


On March 7, 2014, 9:36 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18016/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 9:36 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5626
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5626
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Removing different ways of obtaining suitable hosts. Used built in API "findHostsForMigration" and skipped the test if suitable host is not found instead of throwing assertion error.
> Removed unnecessary common function.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_cpu_domain_limits.py c427e4f 
>   test/integration/component/test_cpu_limits.py bdf2869 
>   test/integration/component/test_cpu_project_limits.py a8a1b3c 
>   test/integration/component/test_memory_limits.py 7921e4b 
>   test/integration/component/test_mm_domain_limits.py 68660c1 
>   test/integration/component/test_mm_project_limits.py c314011 
>   test/integration/component/test_vpc_vm_life_cycle.py 01373ac 
>   tools/marvin/marvin/codes.py 3882f0d 
>   tools/marvin/marvin/integration/lib/common.py b2da3ff 
> 
> Diff: https://reviews.apache.org/r/18016/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>