You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/08/14 18:28:02 UTC
[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11214
Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
......................................................................
[gradle] Aggressively retry downloading the gradle wrapper jar
When downloading the Gradle wrapper jar via curl
builds could fail because we didn’t retry. This patch
adds various ways to retry:
- Adds `—retry 3` to retry transient errors.
- Adds -L to handle when the requested page has
moved to a different location
- Adds -S to show the errors.
- Adds a manual retry loop to retry errors that
curl doesn’t think are transient.
Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 22 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/11214/1
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11214 )
Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 19:53:22 +0000
Gerrit-HasComments: No
[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11214 )
Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
......................................................................
[gradle] Aggressively retry downloading the gradle wrapper jar
When downloading the Gradle wrapper jar via curl
builds could fail because we didn’t retry. This patch
adds various ways to retry:
- Adds `—retry 3` to retry transient errors.
- Adds -L to handle when the requested page has
moved to a different location
- Adds -S to show the errors.
- Adds a manual retry loop to retry errors that
curl doesn’t think are transient.
- Replaces raw.githubusercontent.com usage with
a github.com raw url.
Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Reviewed-on: http://gerrit.cloudera.org:8080/11214
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 23 insertions(+), 7 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11214 )
Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11214/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11214/2//COMMIT_MSG@19
PS2, Line 19: - Replaces raw.githubusercontent.com usage with
: a github.com raw url.
> So this is effectively the same thing?
Yeah, it actually redirects to raw.githubusercontent.com, but the url is less surprising.
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 19:08:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11214 )
Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11214/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11214/2//COMMIT_MSG@19
PS2, Line 19: - Replaces raw.githubusercontent.com usage with
: a github.com raw url.
So this is effectively the same thing?
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 18:56:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11214
to look at the new patch set (#2).
Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
......................................................................
[gradle] Aggressively retry downloading the gradle wrapper jar
When downloading the Gradle wrapper jar via curl
builds could fail because we didn’t retry. This patch
adds various ways to retry:
- Adds `—retry 3` to retry transient errors.
- Adds -L to handle when the requested page has
moved to a different location
- Adds -S to show the errors.
- Adds a manual retry loop to retry errors that
curl doesn’t think are transient.
- Replaces raw.githubusercontent.com usage with
a github.com raw url.
Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 23 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/11214/2
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [gradle] Aggressively retry downloading the gradle wrapper jar
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11214 )
Change subject: [gradle] Aggressively retry downloading the gradle wrapper jar
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b0f9252dbb68b4f6f67c29f9ad02f145e084ba
Gerrit-Change-Number: 11214
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Aug 2018 18:35:22 +0000
Gerrit-HasComments: No