You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/09/10 04:28:21 UTC
Review Request 14057: Empty files are no longer considered as recovery
errors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14057/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-680
https://issues.apache.org/jira/browse/MESOS-680
Repository: mesos-git
Description
-------
We have seen cases where a slave could die after opening a file but before writing anything to it. This fix considers them as acceptable.
Diffs
-----
src/slave/state.cpp c03db32156c49a1b99998f147325d9e43686c396
Diff: https://reviews.apache.org/r/14057/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14057: Empty files are no longer considered as recovery
errors.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14057/#review26010
-----------------------------------------------------------
Ship it!
Patch looks good! Also gave this a quick test on our staging cluster, and it appeared to work as intended.
- Brenden Matthews
On Sept. 10, 2013, 2:28 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14057/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2013, 2:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-680
> https://issues.apache.org/jira/browse/MESOS-680
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We have seen cases where a slave could die after opening a file but before writing anything to it. This fix considers them as acceptable.
>
>
> Diffs
> -----
>
> src/slave/state.cpp c03db32156c49a1b99998f147325d9e43686c396
>
> Diff: https://reviews.apache.org/r/14057/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14057: Empty files are no longer considered as recovery
errors.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14057/
-----------------------------------------------------------
(Updated Sept. 24, 2013, 7:27 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased. NNFR.
Bugs: MESOS-680
https://issues.apache.org/jira/browse/MESOS-680
Repository: mesos-git
Description
-------
We have seen cases where a slave could die after opening a file but before writing anything to it. This fix considers them as acceptable.
Diffs (updated)
-----
src/slave/state.cpp c03db32156c49a1b99998f147325d9e43686c396
Diff: https://reviews.apache.org/r/14057/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14057: Empty files are no longer considered as recovery
errors.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14057/#review26290
-----------------------------------------------------------
Ship it!
src/slave/state.cpp
<https://reviews.apache.org/r/14057/#comment51375>
"framework libprocess pid" as done below for the executor log message
src/slave/state.cpp
<https://reviews.apache.org/r/14057/#comment51376>
"forked executor pid"?
- Ben Mahler
On Sept. 10, 2013, 2:28 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14057/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2013, 2:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-680
> https://issues.apache.org/jira/browse/MESOS-680
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We have seen cases where a slave could die after opening a file but before writing anything to it. This fix considers them as acceptable.
>
>
> Diffs
> -----
>
> src/slave/state.cpp c03db32156c49a1b99998f147325d9e43686c396
>
> Diff: https://reviews.apache.org/r/14057/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>