You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/31 13:31:36 UTC
[GitHub] [rocketmq] Hen1ng opened a new pull request #4075: fix some spell error, eg:mapedFile -> mappedFile
Hen1ng opened a new pull request #4075:
URL: https://github.com/apache/rocketmq/pull/4075
**Make sure set the target branch to `develop`**
## What is the purpose of the change
fix some spell error, eg:maped -> mapped
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Hen1ng commented on a change in pull request #4075: fix some spell error, eg:mapedFile -> mappedFile
Posted by GitBox <gi...@apache.org>.
Hen1ng commented on a change in pull request #4075:
URL: https://github.com/apache/rocketmq/pull/4075#discussion_r840204029
##########
File path: store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java
##########
@@ -84,7 +84,7 @@
@ImportantField
private int fileReservedTime = 72;
// Flow control for ConsumeQueue
- private int putMsgIndexHightWater = 600000;
Review comment:
Could you tell me which doc this field should be addressed？ I just change this field name，I could not find the field named "putMsgIndexHightWater" in any doc under the path rocketmq/docs. thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on a change in pull request #4075: fix some spell error, eg:mapedFile -> mappedFile
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #4075:
URL: https://github.com/apache/rocketmq/pull/4075#discussion_r840139481
##########
File path: store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java
##########
@@ -84,7 +84,7 @@
@ImportantField
private int fileReservedTime = 72;
// Flow control for ConsumeQueue
- private int putMsgIndexHightWater = 600000;
Review comment:
This field should be addressed in our doc. You know, if we do not have any comments, people would feel a little quirk in these points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org