[GitHub] [iceberg] rdblue commented on a diff in pull request #4816: remove operations from base expressions; add in expression

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4816:
URL: https://github.com/apache/iceberg/pull/4816#discussion_r883875936


##########
python/src/iceberg/expressions/base.py:
##########
@@ -137,6 +74,28 @@ def __invert__(self) -> "BooleanExpression":
         ...
 
 
+class BoundPredicate(ABC):
+    def __init__(self, left, right):
+        """A concrete predicate must have a `left` and `right`"""
+        self._left = left
+        self._right = right

Review Comment:
   Let's not worry about the visitor just yet. I think we would probably pass the actual predicate rather than deconstructing it. Otherwise we'd need to reintroduce operation to pass it in.
   
   I agree that this should be more specific about its children. I think it should use `term` (always left) and `literal`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org