You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lw-lin <gi...@git.apache.org> on 2017/02/19 13:42:55 UTC

[GitHub] spark pull request #16987: [SPARK-19633][SS] FileSource read from FileSink

Github user lw-lin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16987#discussion_r101917807
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala ---
    @@ -76,12 +76,13 @@ abstract class FileStreamSourceTest
         protected def addData(source: FileStreamSource): Unit
       }
     
    -  case class AddTextFileData(content: String, src: File, tmp: File)
    -    extends AddFileData {
    +  case class AddTextFileData (
    +      content: String, src: File, tmp: File, finalFileName: Option[String] = None
    +    ) extends AddFileData {
     
         override def addData(source: FileStreamSource): Unit = {
           val tempFile = Utils.tempFileWith(new File(tmp, "text"))
    -      val finalFile = new File(src, tempFile.getName)
    +      val finalFile = new File(src, finalFileName.getOrElse(tempFile.getName))
    --- End diff --
    
    this is to keep track of the file name for later checking


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org