You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/13 08:52:23 UTC

[GitHub] [rocketmq] zcsh0721 commented on pull request #2751: [ISSUE #2750]Remove meaningless code and optimize

zcsh0721 commented on pull request #2751:
URL: https://github.com/apache/rocketmq/pull/2751#issuecomment-818568328


   @maixiaohai  你好,我不太清楚我种修改代码的方式该如何写测试用例.
   首先我是删除无用代码, 且把代码抽离一部分; 组成了一个`getSuggestPullingFromSlave()` 方法. 且我认为他应该是 `private`. 
   因为这不是新增加功能和修复 bug . 所以我认为只要通过原来的测试用例即可. 尽管我想编写一些测试用例,但是这种情况我不知道如何下手; 
   想请教一下............


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org