[GitHub] [beam] robertwb commented on a change in pull request #11740: [BEAM-8019] Prevent Dataflow from starting multiple containers for the same image

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #11740:
URL: https://github.com/apache/beam/pull/11740#discussion_r427646588



##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -310,15 +312,15 @@ def __init__(
         environment_payload = proto_utils.parse_Bytes(
             environment.payload, beam_runner_api_pb2.DockerPayload)
         container_image_url = environment_payload.container_image
-        if container_image_url == pipeline_sdk_container_image:
-          # This was already added
+        if container_image_url in already_added_containers:
+          # Do not add the pipeline environment again.

Review comment:
       Perhaps also add a comment that currently dataflow stages all dependencies to all environments?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org