You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/10/20 03:03:08 UTC

[GitHub] [incubator-gobblin] shirshanka commented on pull request #3131: GOBBLIN-1292: Undo hardcoded tmp directory locations for unit tests

shirshanka commented on pull request #3131:
URL: https://github.com/apache/incubator-gobblin/pull/3131#issuecomment-712557981


   @sv2000 : I think the standardization of how temporary directories are created and how directories from within them are handed out might be useful refactoring for future test writers. They won't need to remember how to create a temp directory, how to combine a temp directory with inner directories etc. 
   I know it seems like a nit, but I think it sets up the "testing harness" in a better way IMO. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org